You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/12 14:43:34 UTC

[GitHub] [airflow] potiuk opened a new pull request #20233: Fix MyPy errors for google.cloud.tasks

potiuk opened a new pull request #20233:
URL: https://github.com/apache/airflow/pull/20233

Part of #19891

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#issuecomment-995040483


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#discussion_r769871239



##########
File path: setup.cfg
##########
@@ -202,6 +202,8 @@ pretty = True
 
 [mypy-airflow.migrations.*]
 ignore_errors = True
+[mypy-google.cloud.tasks_v2.*]

Review comment:
       @uranusjr  - this is soooooo much better :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#issuecomment-993802331


   Also small one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#issuecomment-995203365


   Just dockerhub instabilities (500s when pulling images). Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #20233:
URL: https://github.com/apache/airflow/pull/20233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#issuecomment-994810420


   I will try to get rid of those pesky strict-optional issues before merging :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #20233: Fix MyPy errors for google.cloud.tasks

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #20233:
URL: https://github.com/apache/airflow/pull/20233#issuecomment-994508519


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org