You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2021/01/25 02:37:01 UTC

[jira] [Created] (TEZ-4270) HeartbeatHandlerBase Does Not Need Stop Condition

David Mollitor created TEZ-4270:
-----------------------------------

             Summary: HeartbeatHandlerBase Does Not Need Stop Condition
                 Key: TEZ-4270
                 URL: https://issues.apache.org/jira/browse/TEZ-4270
             Project: Apache Tez
          Issue Type: Improvement
            Reporter: David Mollitor


Currently, the code checks if the thread is interrupted or if some {{stop}} variable is set.  It does not need to do both.  Interrupting a thread is the way to trigger it to stop, no need to add two ways of stopping it.

This is especially useful because the thread is a protected variable and can be interrupted from inheriting classes which may not know about this {{stop}} variable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)