You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/02/08 02:54:25 UTC

[GitHub] [hudi] ZhangChaoming opened a new pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

ZhangChaoming opened a new pull request #2547:
URL: https://github.com/apache/hudi/pull/2547


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
    This pull request fixes the bug that throwing NPE while getting option PATH from configuration and adds the embedded time line server option.
   
   ## Brief change log
   
     - *Modify the configuration for `writeClient` during flink operator initialization.*
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-io commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774916814


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=h1) Report
   > Merging [#2547](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=desc) (b142336) into [master](https://codecov.io/gh/apache/hudi/commit/c30481f4b0d7552a5ac73bb9955f6326f90ba329?el=desc) (c30481f) will **decrease** coverage by `1.80%`.
   > The diff coverage is `9.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/2547/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2547      +/-   ##
   ============================================
   - Coverage     50.90%   49.10%   -1.81%     
   + Complexity     3167     2819     -348     
   ============================================
     Files           433      378      -55     
     Lines         19806    16952    -2854     
     Branches       2032     1713     -319     
   ============================================
   - Hits          10083     8324    -1759     
   + Misses         8904     7970     -934     
   + Partials        819      658     -161     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | hudicli | `36.90% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudicommon | `51.38% <ø> (-0.03%)` | `0.00 <ø> (ø)` | |
   | hudiflink | `43.01% <9.09%> (-0.21%)` | `0.00 <0.00> (ø)` | |
   | hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudisparkdatasource | `?` | `?` | |
   | hudisync | `?` | `?` | |
   | huditimelineservice | `?` | `?` | |
   | hudiutilities | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/hudi/operator/InstantGenerateOperator.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9vcGVyYXRvci9JbnN0YW50R2VuZXJhdGVPcGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...pache/hudi/operator/KeyedWriteProcessFunction.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9vcGVyYXRvci9LZXllZFdyaXRlUHJvY2Vzc0Z1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...src/main/java/org/apache/hudi/sink/CommitSink.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL0NvbW1pdFNpbmsuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS91dGlsL1N0cmVhbWVyVXRpbC5qYXZh) | `44.23% <100.00%> (+0.54%)` | `13.00 <0.00> (ø)` | |
   | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXRXcml0ZXIuamF2YQ==) | `78.12% <0.00%> (-1.57%)` | `26.00% <0.00%> (ø%)` | |
   | [...in/scala/org/apache/hudi/HoodieEmptyRelation.scala](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZUVtcHR5UmVsYXRpb24uc2NhbGE=) | | | |
   | [...nal/HoodieBulkInsertDataInternalWriterFactory.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmsyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2ludGVybmFsL0hvb2RpZUJ1bGtJbnNlcnREYXRhSW50ZXJuYWxXcml0ZXJGYWN0b3J5LmphdmE=) | | | |
   | [.../hive/SlashEncodedHourPartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvU2xhc2hFbmNvZGVkSG91clBhcnRpdGlvblZhbHVlRXh0cmFjdG9yLmphdmE=) | | | |
   | [.../apache/hudi/timeline/service/TimelineService.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvVGltZWxpbmVTZXJ2aWNlLmphdmE=) | | | |
   | [...cala/org/apache/hudi/HoodieBootstrapRelation.scala](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZUJvb3RzdHJhcFJlbGF0aW9uLnNjYWxh) | | | |
   | ... and [50 more](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree-more) | |
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774898088


   @yanghua Done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571849816



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       > You may see my change files. It obvious that the original version did not invokes `FlinkOptions.fromStreamerConfig(conf)` firstly.
   
   @ZhangChaoming Did you update your local code to the same as master? It seems ok in my side
   ```
     public static HoodieWriteConfig getHoodieClientConfig(FlinkStreamerConfig conf) {
       return getHoodieClientConfig(FlinkOptions.fromStreamerConfig(conf));
     }
   
     public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
       HoodieWriteConfig.Builder builder =
           HoodieWriteConfig.newBuilder()
               .withEngineType(EngineType.FLINK)
               .withPath(conf.getString(FlinkOptions.PATH))
               .combineInput(conf.getBoolean(FlinkOptions.INSERT_DROP_DUPS), true)
               .withCompactionConfig(
                   HoodieCompactionConfig.newBuilder()
                       .withPayloadClass(conf.getString(FlinkOptions.PAYLOAD_CLASS))
                       .build())
               .forTable(conf.getString(FlinkOptions.TABLE_NAME))
               .withAutoCommit(false)
               .withProps(flinkConf2TypedProperties(FlinkOptions.flatOptions(conf)));
   
       builder = builder.withSchema(getSourceSchema(conf).toString());
       return builder.build();
     }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming closed pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming closed pull request #2547:
URL: https://github.com/apache/hudi/pull/2547


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774934837


   @yanghua I've put this problem and reason on [HUDI-1596](https://issues.apache.org/jira/browse/HUDI-1596).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571844738



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       You may see my change files. It obvious that the original version did not invokes `FlinkOptions.fromStreamerConfig(conf)` firstly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571851491



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       > You may see my change files. It obvious that the original version did not invokes `FlinkOptions.fromStreamerConfig(conf)` firstly.
   
   Generally, it would be better to rebase to the latest master's snapshot before opening a new PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571834732



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       I saw the description of the Jira issue. It seems `StreamerUtil.getHoodieClientConfig(cfg)` also invokes `FlinkOptions.fromStreamerConfig(conf)` firstly, then call `public static HoodieWriteConfig getHoodieClientConfig(Configuration conf)`. Why your change can fix the NPE?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571820640



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       It seems the `StreamerUtil.getHoodieClientConfig(cfg)` delegates the next two lines?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774922718


   @ZhangChaoming Can you tell me where and how caused the NPE?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774890541


   @ZhangChaoming There is a conflicting file, you may need to rebase to the master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571849816



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       > You may see my change files. It obvious that the original version did not invokes `FlinkOptions.fromStreamerConfig(conf)` firstly.
   
   @ZhangChaoming Did you update your local code? It seems ok on my side
   ```
     public static HoodieWriteConfig getHoodieClientConfig(FlinkStreamerConfig conf) {
       return getHoodieClientConfig(FlinkOptions.fromStreamerConfig(conf));
     }
   
     public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
       HoodieWriteConfig.Builder builder =
           HoodieWriteConfig.newBuilder()
               .withEngineType(EngineType.FLINK)
               .withPath(conf.getString(FlinkOptions.PATH))
               .combineInput(conf.getBoolean(FlinkOptions.INSERT_DROP_DUPS), true)
               .withCompactionConfig(
                   HoodieCompactionConfig.newBuilder()
                       .withPayloadClass(conf.getString(FlinkOptions.PAYLOAD_CLASS))
                       .build())
               .forTable(conf.getString(FlinkOptions.TABLE_NAME))
               .withAutoCommit(false)
               .withProps(flinkConf2TypedProperties(FlinkOptions.flatOptions(conf)));
   
       builder = builder.withSchema(getSourceSchema(conf).toString());
       return builder.build();
     }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774991927


   > It's my mistake that I did not update my local code, greatly appreciate your review. @yanghua @wangxianghu
   
   It does not matter, we really thank you for your contribution to integrating Flink with Hudi!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming commented on a change in pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571825551



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
     writeParallelSize = getRuntimeContext().getExecutionConfig().getParallelism();
 
     // writeClient
-    writeClient = new HoodieFlinkWriteClient<>(new HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)), StreamerUtil.getHoodieClientConfig(cfg));

Review comment:
       I just call `FlinkOptions.fromStreamerConfig(cfg)` firstly to parse the Flink option `PATH` from properties file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] ZhangChaoming commented on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774969059


   It's my mistake that I did not update my local code, greatly appreciate your review. @yanghua @wangxianghu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-io edited a comment on pull request #2547: [HUDI-1596] NPE while getting option PATH from configuration.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#issuecomment-774916814


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=h1) Report
   > Merging [#2547](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=desc) (b142336) into [master](https://codecov.io/gh/apache/hudi/commit/c30481f4b0d7552a5ac73bb9955f6326f90ba329?el=desc) (c30481f) will **decrease** coverage by `0.02%`.
   > The diff coverage is `9.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/2547/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2547      +/-   ##
   ============================================
   - Coverage     50.90%   50.88%   -0.03%     
     Complexity     3167     3167              
   ============================================
     Files           433      433              
     Lines         19806    19814       +8     
     Branches       2032     2032              
   ============================================
   - Hits          10083    10082       -1     
   - Misses         8904     8912       +8     
   - Partials        819      820       +1     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | hudicli | `36.90% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudicommon | `51.38% <ø> (-0.03%)` | `0.00 <ø> (ø)` | |
   | hudiflink | `43.01% <9.09%> (-0.21%)` | `0.00 <0.00> (ø)` | |
   | hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudisparkdatasource | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | huditimelineservice | `66.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
   | hudiutilities | `69.46% <ø> (ø)` | `0.00 <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2547?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/hudi/operator/InstantGenerateOperator.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9vcGVyYXRvci9JbnN0YW50R2VuZXJhdGVPcGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...pache/hudi/operator/KeyedWriteProcessFunction.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9vcGVyYXRvci9LZXllZFdyaXRlUHJvY2Vzc0Z1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...src/main/java/org/apache/hudi/sink/CommitSink.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL0NvbW1pdFNpbmsuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS91dGlsL1N0cmVhbWVyVXRpbC5qYXZh) | `44.23% <100.00%> (+0.54%)` | `13.00 <0.00> (ø)` | |
   | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://codecov.io/gh/apache/hudi/pull/2547/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXRXcml0ZXIuamF2YQ==) | `78.12% <0.00%> (-1.57%)` | `26.00% <0.00%> (ø%)` | |
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org