You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/11/18 18:47:44 UTC
Review Request 28179: CLOUDSTACK-7928 : Fixed the script
'test_vpc_vm_life_cycle.py' - Removed the Invalid test cases for Stopped
VPC VR Scenario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28179/
-----------------------------------------------------------
Review request for cloudstack and sangeetha hariharan.
Bugs: CLOUDSTACK-7928
https://issues.apache.org/jira/browse/CLOUDSTACK-7928
Repository: cloudstack-git
Description
-------
Following Test Cases currently fail in TestVMLifeCycleStoppedVPCVR Test Suite:
test_07_migrate_instance_in_network
test_08_user_data
test_09_meta_data
test_10_expunge_instance_in_network
The test cases fail for the obvious reason since the VPC VR is stopped. The Stopped VPCVR doesnt allow the traffic to or from the Guest VMs. Hence the test cases are not valid to be tested in such a scenario and should be removed.
Removed the test cases that are failing due to invalid scenario
Diffs
-----
test/integration/component/test_vpc_vm_life_cycle.py 7a1fd8a
Diff: https://reviews.apache.org/r/28179/diff/
Testing
-------
Testing not done
Thanks,
Chandan Purushothama
Re: Review Request 28179: CLOUDSTACK-7928 : Fixed the script
'test_vpc_vm_life_cycle.py' - Removed the Invalid test cases for Stopped
VPC VR Scenario
Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28179/#review62071
-----------------------------------------------------------
Ship it!
Ship It!
- sangeetha hariharan
On Nov. 18, 2014, 5:47 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28179/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 5:47 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-7928
> https://issues.apache.org/jira/browse/CLOUDSTACK-7928
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Following Test Cases currently fail in TestVMLifeCycleStoppedVPCVR Test Suite:
>
> test_07_migrate_instance_in_network
> test_08_user_data
> test_09_meta_data
> test_10_expunge_instance_in_network
>
> The test cases fail for the obvious reason since the VPC VR is stopped. The Stopped VPCVR doesnt allow the traffic to or from the Guest VMs. Hence the test cases are not valid to be tested in such a scenario and should be removed.
>
> Removed the test cases that are failing due to invalid scenario
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_vm_life_cycle.py 7a1fd8a
>
> Diff: https://reviews.apache.org/r/28179/diff/
>
>
> Testing
> -------
>
> Testing not done
>
>
> Thanks,
>
> Chandan Purushothama
>
>
Re: Review Request 28179: CLOUDSTACK-7928 : Fixed the script
'test_vpc_vm_life_cycle.py' - Removed the Invalid test cases for Stopped
VPC VR Scenario
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28179/#review79018
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Nov. 18, 2014, 5:47 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28179/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 5:47 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-7928
> https://issues.apache.org/jira/browse/CLOUDSTACK-7928
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Following Test Cases currently fail in TestVMLifeCycleStoppedVPCVR Test Suite:
>
> test_07_migrate_instance_in_network
> test_08_user_data
> test_09_meta_data
> test_10_expunge_instance_in_network
>
> The test cases fail for the obvious reason since the VPC VR is stopped. The Stopped VPCVR doesnt allow the traffic to or from the Guest VMs. Hence the test cases are not valid to be tested in such a scenario and should be removed.
>
> Removed the test cases that are failing due to invalid scenario
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_vm_life_cycle.py 7a1fd8a
>
> Diff: https://reviews.apache.org/r/28179/diff/
>
>
> Testing
> -------
>
> Testing not done
>
>
> Thanks,
>
> Chandan Purushothama
>
>