You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by woowahan-jaehoon <gi...@git.apache.org> on 2018/06/05 12:17:24 UTC

[GitHub] zeppelin pull request #3006: Modify jobGroupId for checking user

GitHub user woowahan-jaehoon opened a pull request:

    https://github.com/apache/zeppelin/pull/3006

    Modify jobGroupId for checking user

    ### What is this PR for?
    Need to check user in jobGroupId
    because when some paragraph is running,
    who run paragraph cannot be found in spark application web UI.
    
    I replace `zeppelin-` to userId.
    I think that 'zeppelin-' is needless because it is already known in spark application.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Modify Code
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3529
    
    ### How should this be tested?
    * Check jobGroupId in Spark Application Web UI of Zeppelin Spark Interpreter
    
    ### Questions:
    * Does the licenses files need update?
        * No
    * Is there breaking changes for older versions?
        * No
    * Does this needs documentation?
        * No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woowabros/zeppelin ZEPPELIN-3529

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3006
    
----
commit c467599e93001e7aab77bb6f93f71ec477f22b49
Author: Jaehoon Jeong <ja...@...>
Date:   2018-06-05T12:02:16Z

    [ZEPPELIN-3529] Modify jobGroupId for checking user

----


---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

Posted by woowahan-jaehoon <gi...@git.apache.org>.

Github user woowahan-jaehoon commented on the issue:

    https://github.com/apache/zeppelin/pull/3006
  
    It tested successful.
    https://travis-ci.org/woowabros/zeppelin/builds/412124390


---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3006
  
    I think this PR's review has done. @woowahan-jaehoon Can you rebase it to make CI green?


---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Modify jobGroupId for checking user

Posted by woowahan-jaehoon <gi...@git.apache.org>.

Github user woowahan-jaehoon commented on the issue:

    https://github.com/apache/zeppelin/pull/3006
  
    @felixcheung, you're right. I modified.


---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

Posted by woowahan-jaehoon <gi...@git.apache.org>.

Github user woowahan-jaehoon commented on the issue:

    https://github.com/apache/zeppelin/pull/3006
  
    Modified and passed tests.
    https://travis-ci.org/woowabros/zeppelin/builds/412253387


---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3006
  
    Can you check one failure of CI? https://travis-ci.org/woowabros/zeppelin/builds/400651878


---