You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/23 20:19:45 UTC

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5855: [RELAY][VM] Add shape_of instruction

icemelon9 commented on pull request #5855:
URL: https://github.com/apache/incubator-tvm/pull/5855#issuecomment-648395868


   I feel we should treat ops like `vm.shape_of` as a dialect for vm. Therefore the conversion from relay ops to vm dialect ops should not be inside the manifest memory pass, but a separate pass. 
   
   @jroesch @tqchen What's your thoughts on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org