You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/10/17 03:27:08 UTC
[kudu-CR] log: rename a couple of things for clarity
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14477
Change subject: log: rename a couple of things for clarity
......................................................................
log: rename a couple of things for clarity
This patch:
- renames Log::DoAppend() to Log::WriteBatch(),
- renames AppendThread::HandleGroup() to AppendThread::HandleBatches(),
- renames AppendThread::WorkerState to AppendThread::ThreadState, to
homogenize the terminology used in that class,
- renames AppendThread::{WORKER_STOPPED,WORKER_ACTIVE} to IDLE and
ACTIVE respectively
I think these names make it slightly more obvious what the functions are
doing.
There are no functional changes here.
Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 38 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14477/1
--
To view, visit http://gerrit.cloudera.org:8080/14477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
Gerrit-Change-Number: 14477
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] log: rename a couple of things for clarity
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14477 )
Change subject: log: rename a couple of things for clarity
......................................................................
Patch Set 2: Code-Review+2
Just rebased.
--
To view, visit http://gerrit.cloudera.org:8080/14477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
Gerrit-Change-Number: 14477
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Oct 2019 17:48:28 +0000
Gerrit-HasComments: No
[kudu-CR] log: rename a couple of things for clarity
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14477 )
Change subject: log: rename a couple of things for clarity
......................................................................
log: rename a couple of things for clarity
This patch:
- renames Log::DoAppend() to Log::WriteBatch(),
- renames AppendThread::HandleGroup() to AppendThread::HandleBatches(),
- renames AppendThread::WorkerState to AppendThread::ThreadState, to
homogenize the terminology used in that class,
- renames AppendThread::{WORKER_STOPPED,WORKER_ACTIVE} to IDLE and
ACTIVE respectively
I think these names make it slightly more obvious what the functions are
doing.
There are no functional changes here.
Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
Reviewed-on: http://gerrit.cloudera.org:8080/14477
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 38 insertions(+), 36 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
Gerrit-Change-Number: 14477
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] log: rename a couple of things for clarity
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14477 )
Change subject: log: rename a couple of things for clarity
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fcaf2656bc31e5015c285392029fa98f6137cef
Gerrit-Change-Number: 14477
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2019 06:47:00 +0000
Gerrit-HasComments: No