You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (JIRA)" <de...@myfaces.apache.org> on 2010/09/05 22:38:34 UTC
[jira] Created: (MYFACES-2910) Allow non-String submitted values
Allow non-String submitted values
----------------------------------
Key: MYFACES-2910
URL: https://issues.apache.org/jira/browse/MYFACES-2910
Project: MyFaces Core
Issue Type: Improvement
Components: JSR-314
Affects Versions: 2.0.2-SNAPSHOT
Environment: myfaces trunk
Reporter: Martin Kočí
Priority: Minor
Myfaces are too strict and always assume submitted value as String. Comparing with Mojarra and Trinidad:
1)org.apache.myfaces.shared.renderkit.RendererUtils.getStringValue(FacesContext, UIComponent):
myfaces: IllegalArgumentException ("Submitted value of type String expected")
mojarra, trinidad: call EditableValueHolder.getSubmittedValue().toString() in this situation
2) org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUIOutputValue(FacesContext, UIOutput, Object)
myfaces: IllegalArgumentException("Submitted value of type String expected")
mojarra: CastClassExpection if sumbittedValue is not String
trinidad: class submittedValue.toString in this situation
toString() solution will handle all situations and will allow submitted values other type than String
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2910) Allow non-String submitted values
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-2910:
------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Yes, I think it is ok to call toString from that method too. Thanks to Martin Kočí for provide this patch
> Allow non-String submitted values
> ----------------------------------
>
> Key: MYFACES-2910
> URL: https://issues.apache.org/jira/browse/MYFACES-2910
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.2-SNAPSHOT
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-2910.patch
>
>
> Myfaces are too strict and always assume submitted value as String. Comparing with Mojarra and Trinidad:
> 1)org.apache.myfaces.shared.renderkit.RendererUtils.getStringValue(FacesContext, UIComponent):
> myfaces: IllegalArgumentException ("Submitted value of type String expected")
> mojarra, trinidad: call EditableValueHolder.getSubmittedValue().toString() in this situation
> 2) org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUIOutputValue(FacesContext, UIOutput, Object)
> myfaces: IllegalArgumentException("Submitted value of type String expected")
> mojarra: CastClassExpection if sumbittedValue is not String
> trinidad: class submittedValue.toString in this situation
> toString() solution will handle all situations and will allow submitted values other type than String
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2910) Allow non-String submitted values
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907141#action_12907141 ]
Matthias Weßendorf commented on MYFACES-2910:
---------------------------------------------
more on calling toString()
http://markmail.org/message/xzj4c6pevmpf33cq
> Allow non-String submitted values
> ----------------------------------
>
> Key: MYFACES-2910
> URL: https://issues.apache.org/jira/browse/MYFACES-2910
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.2-SNAPSHOT
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-2910.patch
>
>
> Myfaces are too strict and always assume submitted value as String. Comparing with Mojarra and Trinidad:
> 1)org.apache.myfaces.shared.renderkit.RendererUtils.getStringValue(FacesContext, UIComponent):
> myfaces: IllegalArgumentException ("Submitted value of type String expected")
> mojarra, trinidad: call EditableValueHolder.getSubmittedValue().toString() in this situation
> 2) org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUIOutputValue(FacesContext, UIOutput, Object)
> myfaces: IllegalArgumentException("Submitted value of type String expected")
> mojarra: CastClassExpection if sumbittedValue is not String
> trinidad: class submittedValue.toString in this situation
> toString() solution will handle all situations and will allow submitted values other type than String
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2910) Allow non-String submitted values
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907140#action_12907140 ]
Matthias Weßendorf commented on MYFACES-2910:
---------------------------------------------
.toString() is acutally right - but not sure what the TCK says...
would be interesting to test it
> Allow non-String submitted values
> ----------------------------------
>
> Key: MYFACES-2910
> URL: https://issues.apache.org/jira/browse/MYFACES-2910
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.2-SNAPSHOT
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Priority: Minor
> Attachments: MYFACES-2910.patch
>
>
> Myfaces are too strict and always assume submitted value as String. Comparing with Mojarra and Trinidad:
> 1)org.apache.myfaces.shared.renderkit.RendererUtils.getStringValue(FacesContext, UIComponent):
> myfaces: IllegalArgumentException ("Submitted value of type String expected")
> mojarra, trinidad: call EditableValueHolder.getSubmittedValue().toString() in this situation
> 2) org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUIOutputValue(FacesContext, UIOutput, Object)
> myfaces: IllegalArgumentException("Submitted value of type String expected")
> mojarra: CastClassExpection if sumbittedValue is not String
> trinidad: class submittedValue.toString in this situation
> toString() solution will handle all situations and will allow submitted values other type than String
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2910) Allow non-String submitted values
Posted by "Martin Kočí (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Kočí updated MYFACES-2910:
---------------------------------
Status: Patch Available (was: Open)
> Allow non-String submitted values
> ----------------------------------
>
> Key: MYFACES-2910
> URL: https://issues.apache.org/jira/browse/MYFACES-2910
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.2-SNAPSHOT
> Environment: myfaces trunk
> Reporter: Martin Kočí
> Priority: Minor
>
> Myfaces are too strict and always assume submitted value as String. Comparing with Mojarra and Trinidad:
> 1)org.apache.myfaces.shared.renderkit.RendererUtils.getStringValue(FacesContext, UIComponent):
> myfaces: IllegalArgumentException ("Submitted value of type String expected")
> mojarra, trinidad: call EditableValueHolder.getSubmittedValue().toString() in this situation
> 2) org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedUIOutputValue(FacesContext, UIOutput, Object)
> myfaces: IllegalArgumentException("Submitted value of type String expected")
> mojarra: CastClassExpection if sumbittedValue is not String
> trinidad: class submittedValue.toString in this situation
> toString() solution will handle all situations and will allow submitted values other type than String
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.