[GitHub] [gobblin] homatthew commented on a diff in pull request #3677: [GOBBLIN-1813] Helix workflows submission timeouts are configurable

["homatthew (via GitHub)" <gi...@apache.org>]

homatthew commented on code in PR #3677:
URL: https://github.com/apache/gobblin/pull/3677#discussion_r1164658958


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java:
##########
@@ -326,7 +327,10 @@ private void runJobExecutionLauncher() throws JobException {
         // make sure the planning job is initialized (or visible) to other parallel running threads,
         // so that the same critical section check (querying Helix for job completeness)
         // can be applied.
-        HelixUtils.waitJobInitialization(planningJobHelixManager, newPlanningId, newPlanningId);
+        Duration submissionTimeout = Duration.ofSeconds(PropertiesUtils

Review Comment:
   The planning job (i.e. distributed mode) is used in GaaS. This change is usable by GaaS in the event that GaaS also sees similar Helix / ZK bottlenecks. 
   
   The default is the same as the previous 5 minute wait, so it is backwards compatible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org