You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2015/05/01 16:44:38 UTC
[GitHub] storm pull request: STORM-807: quote args correctly
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/541
STORM-807: quote args correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-807
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #541
----
commit ca3f7629af93c9d173cc00ab5f3dd5351fb3c669
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-05-01T14:39:45Z
STORM-807: quote args correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-98489207
LGTM = Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-99993456
@ptgoetz never mind, JIRA is off STORM-675 said it went into 0.10.0, but it did not. I will just merge this to trunk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-98738898
@liaokevin previously bin/storm was a python script but recently it changed to a shell script that wraps the original python script. The shell script did not quote arguments passed to the python script correctly so if I ran.
```./storm list "a b" c d```
it would not honor the quotes around "a b" and treat them as separate arguments. This is a problem if we include space in the name of a topology, or if we try to add a config to the command line with a space in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by liaokevin <gi...@git.apache.org>.
Github user liaokevin commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-98436014
What you mean
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-99913145
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-98272128
LGTM, I've confirmed with print COMMAND and ARGS.
Before applying
```
$ ./storm list "a b" c d
list
['a', 'b', 'c', 'd']
```
After applying
```
$ ./storm list "a b" c d
list
['a b', 'c', 'd']
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-807: quote args correctly
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/541#issuecomment-99991835
@ptgoetz I am merging this into 0.10.x-branch as well, because it was introduced there. If you disagree please let me know and I will revert it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---