[GitHub] [geode] moleske opened pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["moleske (GitHub)" <gi...@apache.org>]

@steve-sienk @BalaKaza 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["aaronlindsey (GitHub)" <gi...@apache.org>]

The `docker` task should probably depend on whatever task generates the `build/install/apache-geode` directory (maybe `installDist`?) But that could also be a separate PR.

[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske closed pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["moleske (GitHub)" <gi...@apache.org>]

[ pull request closed by moleske ]

[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Should definitely have a 'dependsOn `installDist`

[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["moleske (GitHub)" <gi...@apache.org>]

All the references in the other Dockerfiles in Geode all use openjdk, so it seemed out to make this one different.  Might worth having a discussion outside of this PR and then open a new PR switching this to adoptopenjdk

[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #4573: GEODE-7651: Provide docker target for geode-assembly

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Hurray for alphabetizing!

[ Full content available at: https://github.com/apache/geode/pull/4573 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org