[jira] [Commented] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987399#comment-14987399 ] 

ASF GitHub Bot commented on THRIFT-3407:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/678

    THRIFT-3407 Refill buffer when JSON closing bracket is missing

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3407

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #678
    
----
commit 1db3e4af072f9db62ff640b9a4ff09cf189ef544
Author: Nobuaki Sukegawa <ns...@apache.org>
Date:   2015-11-03T13:58:20Z

    THRIFT-3407 Refill buffer when JSON closing bracket is missing

----


> Refill buffer when JSON closing bracket is missing
> --------------------------------------------------
>
>                 Key: THRIFT-3407
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3407
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.9.3
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>
> NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller than that of opening brackets.
> It is problematic because it is not guaranteed if the transport reads the whole JSON message at once or not.
> Practically, sending big JSON message over buffered tranpsort is being unstable because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)