[GitHub] [airflow] ashb commented on a change in pull request #16659: Refactor: Remove processor_factory from DAG processing

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #16659:
URL: https://github.com/apache/airflow/pull/16659#discussion_r664375840



##########
File path: airflow/dag_processing/manager.py
##########
@@ -1022,8 +1012,8 @@ def start_new_processes(self):
                 continue
 
             callback_to_execute_for_file = self._callback_to_execute[file_path]
-            processor = self._processor_factory(
-                file_path, callback_to_execute_for_file, self._dag_ids, self._pickle_dags
+            processor = type(self)._create_process(

Review comment:
       `type(self)._create_process` is a "trick" to avoid multiprocessing pickling more than it should (taken from the MP source code), which was important when the factory method was being sent from the Scheduler to the DagFileProcessorManager over a multiprocessing connection
   
   But since we are now just creating the processor, rather than passing a reference to the the factory, we can do as Jed suggests.
   
   And `self._some_static_method` works fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org