[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2202: [KYUUBI #2201] Show ExecutionId when running status on query engine page

[GitBox <gi...@apache.org>]

cxzl25 commented on code in PR #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r851644028


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -154,8 +153,27 @@ class ExecuteStatement(
   }
 
   override def setState(newState: OperationState): Unit = {
+    setStateInt(newState)
+  }
+
+  private def setStateInt(newState: OperationState, startTime: Option[Long] = None): Unit = {
     super.setState(newState)
+    if (startTime.isDefined) {
+      this.startTime = startTime.get

Review Comment:
   When the `newState` of `AbstractOperation#setState` is `running`, `startTime` will be assigned the millisecond of the current time, so I can only reassign `startTime` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org