You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by feynmanliang <gi...@git.apache.org> on 2015/09/15 01:41:36 UTC

[GitHub] spark pull request: [SPARK-9962][ML] Decision Tree training: prevN...

Github user feynmanliang commented on the pull request:

    https://github.com/apache/spark/pull/8541#issuecomment-140234135
  
    Changes LGTM (renaming public method but the class is package private), but why do we need this (CC @jkbradley)? `prevNodeIdsForInstances` is never persisted in the first place


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org