You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nico Kadel-Garcia <nk...@gmail.com> on 2012/08/18 16:53:48 UTC
Please move mod_dontdothat back from tools/server-side/mod_dontdothat
to subversion/mod_dontdothat
There was a thread on this in users@subvesion.org, I think I've boiled
it down enough for dev to look at it.
To sum up, please revert r1307177, and move
tools/server-side/mod_dontdothat back to the
subversion/mod_dontdothat.
Unless there is a plan to migrate *all* the subversion/mod_*
components over to tools/server-side/mod_*, I'm looking at the code
and just don't see why this component should should be so distinct.
I'm afraid that sprinkling the HTTPD modules into separate compilation
and deployment locations is just going to create ongoing surprises. It
already bit me in RPM compilation and management. I see the code
danielsh wen into to do this, but unless the mod_dav_svn and
mod_authz_svn tools are also going to migrate to tools/server-side, I
think it's going to be safer to manage whee it was in the
subversion-1.7.5 tag.
Nico Kadel-Garcia <nk...@gmail.com>
Re: Please move mod_dontdothat back from
tools/server-side/mod_dontdothat to subversion/mod_dontdothat
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Blair Zajac wrote on Sun, Aug 19, 2012 at 12:18:59 -0700:
> On 08/19/2012 11:02 AM, Branko Čibej wrote:
> >On 18.08.2012 16:53, Nico Kadel-Garcia wrote:
> >mod_dontdothat is not a core module. It's effectively a debugging tool.
> >Whereas mod_dav_svn and mod_authz_svn are part of the core Subversion
> >functionality. The different locations aren't accidental.
> >
> >The main problem with moving mod_dontdothat was that the way it was done
> >broke Unix builds without Apache HTTPd. That's fixed on trunk now, and
> >could probably be backported to 1.7.x.
>
> There's some downstream maintainers I know that would appreciate
> that ;) Which revisions need backporting so I can review and vote
> on them?
>
There is an r1374198 in STATUS. (It mentions a trunk follow-up commit,
too, which is not nominated for backport.)
> Blair
>
>
Re: Please move mod_dontdothat back from tools/server-side/mod_dontdothat
to subversion/mod_dontdothat
Posted by Branko Čibej <br...@wandisco.com>.
On 19.08.2012 21:18, Blair Zajac wrote:
> On 08/19/2012 11:02 AM, Branko Čibej wrote:
>> On 18.08.2012 16:53, Nico Kadel-Garcia wrote:
>> mod_dontdothat is not a core module. It's effectively a debugging tool.
>> Whereas mod_dav_svn and mod_authz_svn are part of the core Subversion
>> functionality. The different locations aren't accidental.
>>
>> The main problem with moving mod_dontdothat was that the way it was done
>> broke Unix builds without Apache HTTPd. That's fixed on trunk now, and
>> could probably be backported to 1.7.x.
>
> There's some downstream maintainers I know that would appreciate that
> ;) Which revisions need backporting so I can review and vote on them?
r1374198 moves mod_dontdothat back into the apache-mod install group,
thus fixing the original dependency problem. That's already proposed for
backport.
r1374357 adds a new feature to the makefile generator that allows us to
make the building of apache modules conditional on a configuration
variable, and moves mod_dontdothat back into the tools install group.
I've not yet proposed this for backport because it's quite invasive, and
would definitely appreciate a review.
-- Brane
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Re: Please move mod_dontdothat back from tools/server-side/mod_dontdothat
to subversion/mod_dontdothat
Posted by Blair Zajac <bl...@orcaware.com>.
On 08/19/2012 11:02 AM, Branko Čibej wrote:
> On 18.08.2012 16:53, Nico Kadel-Garcia wrote:
> mod_dontdothat is not a core module. It's effectively a debugging tool.
> Whereas mod_dav_svn and mod_authz_svn are part of the core Subversion
> functionality. The different locations aren't accidental.
>
> The main problem with moving mod_dontdothat was that the way it was done
> broke Unix builds without Apache HTTPd. That's fixed on trunk now, and
> could probably be backported to 1.7.x.
There's some downstream maintainers I know that would appreciate that ;)
Which revisions need backporting so I can review and vote on them?
Blair
Re: Please move mod_dontdothat back from tools/server-side/mod_dontdothat
to subversion/mod_dontdothat
Posted by Branko Čibej <br...@wandisco.com>.
On 18.08.2012 16:53, Nico Kadel-Garcia wrote:
> There was a thread on this in users@subvesion.org, I think I've boiled
> it down enough for dev to look at it.
>
> To sum up, please revert r1307177, and move
> tools/server-side/mod_dontdothat back to the
> subversion/mod_dontdothat.
>
> Unless there is a plan to migrate *all* the subversion/mod_*
> components over to tools/server-side/mod_*, I'm looking at the code
> and just don't see why this component should should be so distinct.
> I'm afraid that sprinkling the HTTPD modules into separate compilation
> and deployment locations is just going to create ongoing surprises. It
> already bit me in RPM compilation and management. I see the code
> danielsh wen into to do this, but unless the mod_dav_svn and
> mod_authz_svn tools are also going to migrate to tools/server-side, I
> think it's going to be safer to manage whee it was in the
> subversion-1.7.5 tag.
>
> Nico Kadel-Garcia <nk...@gmail.com>
mod_dontdothat is not a core module. It's effectively a debugging tool.
Whereas mod_dav_svn and mod_authz_svn are part of the core Subversion
functionality. The different locations aren't accidental.
The main problem with moving mod_dontdothat was that the way it was done
broke Unix builds without Apache HTTPd. That's fixed on trunk now, and
could probably be backported to 1.7.x.
-- Brane
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download