You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prashantwason (via GitHub)" <gi...@apache.org> on 2023/04/11 17:17:07 UTC
[GitHub] [hudi] prashantwason opened a new pull request, #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
prashantwason opened a new pull request, #8430:
URL: https://github.com/apache/hudi/pull/8430
[HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
### Change Logs
1. Added config to enable backing up instants
2. Added config for location of backup directory
3. Added code to backup
### Impact
None. New feature is off by default.
### Risk level (write none, low medium or high below)
None
### Documentation Update
Config has the necessary docstring.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1540229899
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
}, {
"hash" : "859896da9470f31eaff15002d448a81dc4350764",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "859896da9470f31eaff15002d448a81dc4350764",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263)
* 859896da9470f31eaff15002d448a81dc4350764 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1539199151
hey @prashantwason : ping me once the feedback is addresssed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1540172472
@nsivabalan I have addressed all the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1503818107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d357330a200b9c5ad7f719d9985d40ef2e604d51 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #8430:
URL: https://github.com/apache/hudi/pull/8430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1559891391
@nsivabalan I have address all your feedback. Ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1188608944
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -828,4 +829,17 @@ protected Option<byte[]> readDataFromPath(Path detailPath) {
public HoodieActiveTimeline reload() {
return new HoodieActiveTimeline(metaClient);
}
+
+ public void copyInstant(HoodieInstant instant, Path dstDir) {
+ Path srcPath = new Path(metaClient.getMetaPath(), instant.getFileName());
+ Path dstPath = new Path(dstDir, instant.getFileName());
+ try {
+ FileSystem srcFs = srcPath.getFileSystem(metaClient.getHadoopConf());
+ FileSystem dstFs = dstPath.getFileSystem(metaClient.getHadoopConf());
+ dstFs.mkdirs(dstDir);
+ FileUtil.copy(srcFs, srcPath, dstFs, dstPath, false, srcFs.getConf());
Review Comment:
5th arg is deleteSource. Changed the API to use a different version of copy which accepts the 6th argument as overwrite flag which is set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1541009350
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
}, {
"hash" : "859896da9470f31eaff15002d448a81dc4350764",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16979",
"triggerID" : "859896da9470f31eaff15002d448a81dc4350764",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 859896da9470f31eaff15002d448a81dc4350764 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16979)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1503828676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1182226644
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -297,4 +301,35 @@ protected void dropBootstrapIndexIfNeeded(HoodieInstant instantToRollback) {
BootstrapIndex.getBootstrapIndex(table.getMetaClient()).dropIndex();
}
}
+
+ private void backupRollbackInstantsIfNeeded() {
+ if (!config.shouldBackupRollbacks()) {
+ // Backup not required
+ return;
+ }
+
+ Path backupDir = new Path(config.getRollbackBackupDirectory());
+ if (!backupDir.isAbsolute()) {
+ // Path specified is relative to the meta directory
+ backupDir = new Path(table.getMetaClient().getMetaPath(), config.getRollbackBackupDirectory());
+ }
+
+ // Determine the instants to backup. Completed and inflight instants are backed up.
+ HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
+ List<HoodieInstant> instantsToBackup = new ArrayList<HoodieInstant>(3);
+ instantsToBackup.add(instantToRollback);
Review Comment:
Some question:
1. why we also back up the inflight instant when the instant is complete?
2. what kind of info from the instant is useful for debugging from your side, can we make it more light-weight?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1504104816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1185522435
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
+ .defaultValue(false)
+ .withDocumentation("Backup instants removed during rollback and restore (useful for debugging)");
+
+ public static final ConfigProperty<String> ROLLBACK_BACKUP_DIRECTORY = ConfigProperty
+ .key("hoodie.rollback.backup.dir")
Review Comment:
hoodie.rollback.timeline.backup.dir
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
Review Comment:
can we add "timeline" may be to the name. not very apparent. seems like entire data might be backedup.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
+ .defaultValue(false)
+ .withDocumentation("Backup instants removed during rollback and restore (useful for debugging)");
+
+ public static final ConfigProperty<String> ROLLBACK_BACKUP_DIRECTORY = ConfigProperty
+ .key("hoodie.rollback.backup.dir")
+ .defaultValue(".rollback_backup")
+ .withDocumentation("Path where instants being rolled back are copied. If not absolute path then a directoruy relative to .hoodie folder is created.");
Review Comment:
typo "directoruy"
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -828,4 +829,17 @@ protected Option<byte[]> readDataFromPath(Path detailPath) {
public HoodieActiveTimeline reload() {
return new HoodieActiveTimeline(metaClient);
}
+
+ public void copyInstant(HoodieInstant instant, Path dstDir) {
+ Path srcPath = new Path(metaClient.getMetaPath(), instant.getFileName());
+ Path dstPath = new Path(dstDir, instant.getFileName());
+ try {
+ FileSystem srcFs = srcPath.getFileSystem(metaClient.getHadoopConf());
+ FileSystem dstFs = dstPath.getFileSystem(metaClient.getHadoopConf());
+ dstFs.mkdirs(dstDir);
+ FileUtil.copy(srcFs, srcPath, dstFs, dstPath, false, srcFs.getConf());
Review Comment:
lets make 5th arg as true. on crash scenarios, if we retry to back up again, we should not fail.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -297,4 +301,35 @@ protected void dropBootstrapIndexIfNeeded(HoodieInstant instantToRollback) {
BootstrapIndex.getBootstrapIndex(table.getMetaClient()).dropIndex();
}
}
+
+ private void backupRollbackInstantsIfNeeded() {
+ if (!config.shouldBackupRollbacks()) {
+ // Backup not required
+ return;
+ }
+
+ Path backupDir = new Path(config.getRollbackBackupDirectory());
+ if (!backupDir.isAbsolute()) {
+ // Path specified is relative to the meta directory
+ backupDir = new Path(table.getMetaClient().getMetaPath(), config.getRollbackBackupDirectory());
+ }
+
+ // Determine the instants to backup. Completed and inflight instants are backed up.
+ HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
+ List<HoodieInstant> instantsToBackup = new ArrayList<HoodieInstant>(3);
+ instantsToBackup.add(instantToRollback);
+ if (instantToRollback.isCompleted()) {
+ instantsToBackup.add(HoodieTimeline.getInflightInstant(instantToRollback, table.getMetaClient()));
Review Comment:
lets ensure we backup all 3 if present. (requested, inflight and completed instant)
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -297,4 +301,35 @@ protected void dropBootstrapIndexIfNeeded(HoodieInstant instantToRollback) {
BootstrapIndex.getBootstrapIndex(table.getMetaClient()).dropIndex();
}
}
+
+ private void backupRollbackInstantsIfNeeded() {
+ if (!config.shouldBackupRollbacks()) {
+ // Backup not required
+ return;
+ }
+
+ Path backupDir = new Path(config.getRollbackBackupDirectory());
+ if (!backupDir.isAbsolute()) {
+ // Path specified is relative to the meta directory
+ backupDir = new Path(table.getMetaClient().getMetaPath(), config.getRollbackBackupDirectory());
+ }
+
+ // Determine the instants to backup. Completed and inflight instants are backed up.
+ HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
+ List<HoodieInstant> instantsToBackup = new ArrayList<HoodieInstant>(3);
+ instantsToBackup.add(instantToRollback);
Review Comment:
this is inline w/ what we do for archival. we will retain entire history. also helps w/ investigation w/ metadata going out of sync may be.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
Review Comment:
hoodie.rollback.timeline.backup.enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1185677116
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
Review Comment:
hoodie.rollback.instant.backup.enabled should be better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1188596238
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
+ .defaultValue(false)
+ .withDocumentation("Backup instants removed during rollback and restore (useful for debugging)");
+
+ public static final ConfigProperty<String> ROLLBACK_BACKUP_DIRECTORY = ConfigProperty
+ .key("hoodie.rollback.backup.dir")
Review Comment:
Renamed to hoodie.rollback.instant.backup.dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8430:
URL: https://github.com/apache/hudi/pull/8430#discussion_r1188595809
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -663,6 +663,16 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+ public static final ConfigProperty<Boolean> ROLLBACK_BACKUP_ENABLED = ConfigProperty
+ .key("hoodie.rollback.backup.enabled")
Review Comment:
Renamed to hoodie.rollback.instant.backup.enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8430:
URL: https://github.com/apache/hudi/pull/8430#issuecomment-1540247216
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263",
"triggerID" : "d357330a200b9c5ad7f719d9985d40ef2e604d51",
"triggerType" : "PUSH"
}, {
"hash" : "859896da9470f31eaff15002d448a81dc4350764",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16979",
"triggerID" : "859896da9470f31eaff15002d448a81dc4350764",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16263)
* 859896da9470f31eaff15002d448a81dc4350764 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16979)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org