You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 01:37:08 UTC
Review Request 70950: Added a registry field for `QuotaConfig`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70950/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9601
https://issues.apache.org/jira/browse/MESOS-9601
Repository: mesos
Description
-------
A new field called `quota_configs` is added to persist the
quota configurations of the cluster. This replaces the old
`quotas` field which is deprecated and will be removed
along with `SET_QUOTA` and `REMOVE_QUOTA` in Mesos 2.0.
Diffs
-----
src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685
Diff: https://reviews.apache.org/r/70950/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70950: Added a registry field for `QuotaConfig`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70950/#review216205
-----------------------------------------------------------
Ship it!
src/master/registry.proto
Lines 136-138 (original), 136-138 (patched)
<https://reviews.apache.org/r/70950/#comment303292>
not yours, but strange comment..
src/master/registry.proto
Lines 140-152 (patched)
<https://reviews.apache.org/r/70950/#comment303291>
thanks!
src/master/registry.proto
Lines 154 (patched)
<https://reviews.apache.org/r/70950/#comment303290>
thanks for the ticket!
- Benjamin Mahler
On June 26, 2019, 1:37 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70950/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 1:37 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9601
> https://issues.apache.org/jira/browse/MESOS-9601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new field called `quota_configs` is added to persist the
> quota configurations of the cluster. This replaces the old
> `quotas` field which is deprecated and will be removed
> in Mesos 2.0.
>
> When users upgrade to Mesos 1.9, `quotas` will be preserved
> and recovered and `quota_configs` will be empty. As users
> configures new quotas, whether through the new `UPDATE_QUOTA`
> call or the deprecated `SET_QUTOA` call, the configured quotas
> will be persisted into the `quota_configs` field along with the
> `QUOTA_V2` minimum capability. The capability is removed only
> if `quota_configs` becomes empty again. If a role already has an
> entry in the old `quotas` field, it will be removed from `quotas`.
> In other words, once upgraded, `quotas` will still be preserved
> and honored, but it will never grow. Instead it will gradually
> shrink as the roles' quotas get updated or removed.
>
>
> Diffs
> -----
>
> src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685
>
>
> Diff: https://reviews.apache.org/r/70950/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70950: Added a registry field for `QuotaConfig`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On June 26, 2019, 12:22 p.m., Benjamin Mahler wrote:
> > Can you also expand the commit description with a more precise comment about how these two fields will be used?
Done.
> On June 26, 2019, 12:22 p.m., Benjamin Mahler wrote:
> > src/master/registry.proto
> > Lines 140-141 (patched)
> > <https://reviews.apache.org/r/70950/diff/2/?file=2152269#file2152269line140>
> >
> > Can you file a ticket that tracks this removal for the 2.0 timeframe and link it here?
MESOS-9866
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70950/#review216157
-----------------------------------------------------------
On June 25, 2019, 6:37 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70950/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 6:37 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9601
> https://issues.apache.org/jira/browse/MESOS-9601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new field called `quota_configs` is added to persist the
> quota configurations of the cluster. This replaces the old
> `quotas` field which is deprecated and will be removed
> in Mesos 2.0.
>
>
> Diffs
> -----
>
> src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685
>
>
> Diff: https://reviews.apache.org/r/70950/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70950: Added a registry field for `QuotaConfig`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70950/#review216157
-----------------------------------------------------------
Can you also expand the commit description with a more precise comment about how these two fields will be used?
src/master/registry.proto
Lines 136-139 (original), 136-147 (patched)
<https://reviews.apache.org/r/70950/#comment303197>
Ditto comment from the last review. After discussing this offline and understanding the overall approach, it's clear that someone looking at these two fields will not understand the overall approach taken.
Can you add a guiding comment here about these two fields? Might as well group them together:
```
// GUIDING COMMENT
repeated Quota quotas = 5 [deprecated = true];
repeated quota.QuotaConfig quota_configs = 11;
```
src/master/registry.proto
Lines 140-141 (patched)
<https://reviews.apache.org/r/70950/#comment303195>
Can you file a ticket that tracks this removal for the 2.0 timeframe and link it here?
- Benjamin Mahler
On June 26, 2019, 1:37 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70950/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 1:37 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9601
> https://issues.apache.org/jira/browse/MESOS-9601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new field called `quota_configs` is added to persist the
> quota configurations of the cluster. This replaces the old
> `quotas` field which is deprecated and will be removed
> in Mesos 2.0.
>
>
> Diffs
> -----
>
> src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685
>
>
> Diff: https://reviews.apache.org/r/70950/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>