You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/19 16:53:12 UTC
Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12
Diff: https://reviews.apache.org/r/42505/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/#review115304
-----------------------------------------------------------
src/master/validation.cpp (lines 206 - 210)
<https://reviews.apache.org/r/42505/#comment176273>
You still need to do this check for disk resource that's persistent volume?
- Jie Yu
On Jan. 19, 2016, 3:53 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42505/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 3:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12
>
> Diff: https://reviews.apache.org/r/42505/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 1:20 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4403
https://issues.apache.org/jira/browse/MESOS-4403
Repository: mesos
Description
-------
Multiple Disk: Adjusted DiskInfo validation.
Diffs
-----
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42505/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 10:54 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Repository: mesos
Description
-------
Multiple Disk: Adjusted DiskInfo validation.
Diffs (updated)
-----
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42505/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/#review115896
-----------------------------------------------------------
Ship it!
src/common/resources.cpp (line 685)
<https://reviews.apache.org/r/42505/#comment176944>
insert a blank line above?
src/common/resources.cpp (line 687)
<https://reviews.apache.org/r/42505/#comment176945>
insert a blank line above?
src/v1/resources.cpp (line 685)
<https://reviews.apache.org/r/42505/#comment176946>
Ditto.
src/v1/resources.cpp (line 687)
<https://reviews.apache.org/r/42505/#comment176947>
Ditto.
- Jie Yu
On Jan. 22, 2016, 9:33 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42505/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:33 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted DiskInfo validation.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42505/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:33 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Used an alias to make conditional more readable.
Removed extra `Resource::validation` check.
Repository: mesos
Description
-------
Multiple Disk: Adjusted DiskInfo validation.
Diffs (updated)
-----
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42505/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/#review115707
-----------------------------------------------------------
src/common/resources.cpp (lines 694 - 705)
<https://reviews.apache.org/r/42505/#comment176730>
I would probably save the 'source' reference first to avoid calling `resource.disk().source()` multiple times:
```
const Resource::DiskInfo& disk = resource.disk();
...
if (resource.disk().has_source()) {
const Resource::DiskInfo::Source& source = resource.disk().source();
if (source.type() == ... && !source.has_path()) {
...
}
...
}
```
src/master/validation.cpp (lines 180 - 184)
<https://reviews.apache.org/r/42505/#comment176732>
This is not needed. This is already called in `resource::validate`.
- Jie Yu
On Jan. 21, 2016, 7:40 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42505/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 7:40 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted DiskInfo validation.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42505/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 7:40 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Added support for `Mount` type.
Addressed issues.
Repository: mesos
Description (updated)
-------
Multiple Disk: Adjusted DiskInfo validation.
Diffs (updated)
-----
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42505/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/#review115482
-----------------------------------------------------------
src/master/validation.cpp (lines 206 - 210)
<https://reviews.apache.org/r/42505/#comment176465>
Also, master valiation is not sufficient because operators can specify it through --resources as well. Can we move this check to Resources::validate.
- Jie Yu
On Jan. 19, 2016, 3:53 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42505/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 3:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12
>
> Diff: https://reviews.apache.org/r/42505/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>