You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/23 02:57:21 UTC
[GitHub] [skywalking] lijial opened a new issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
lijial opened a new issue #6061:
URL: https://github.com/apache/skywalking/issues/6061
Dear skywalking team.
As I read skywalking agent code, **agent.sample_n_per_3_secs** this config stands for upper limit of TraceSegment, is it right?
As one TraceSegment can hold many segment, just suppose 1 TraceSegment has 3 spans,
if **agent.sample_n_per_3_secs** set to 150, then the upper limit of spans has been 450.
Is it right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749898075
Yes, but span doesn't matter for SkyWalking, especially at the storage level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
@wu-sheng
> Yes, but span doesn't matter for SkyWalking, especially at the storage level.
**agent.sample_n_per_3_secs** config cannot measure network flow accuracy
Even **agent.sample_n_per_3_secs** is numeric small , but the whole network flow could be numeric big.
The more spans, the high network flow.
So I think agent.config need a new config **agent.spans_n_per_3_secs**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
@wu-sheng
> Yes, but span doesn't matter for SkyWalking, especially at the storage level.
**agent.sample_n_per_3_secs** config cannot measure network flow accuracy
Even **agent.sample_n_per_3_secs** is numeric small , but the whole network flow could be numeric big.
The more spans, the high network flow.
So I would think agent.config need a new config **agent.spans_n_per_3_secs**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749917429
Read the document, there is a config called `SPAN_LIMIT_PER_SEGMENT` to do this. But less spans could break your traces, do the client side tracing is not working because of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
@wu-sheng
>Yes, but span doesn't matter for SkyWalking, especially at the storage level.
**agent.sample_n_per_3_secs** config cannot measure network flow accuracy
Even **agent.sample_n_per_3_secs** is numeric small , but the whole network flow could be numeric big.
The more spans, the high network flow.
So I would think agent.config need a new config **agent.spans_n_per_3_secs**
Network flow means from javaagent trace data to collector, As high network flow would influence app.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749928959
> Read the document, there is a config called `SPAN_LIMIT_PER_SEGMENT` to do this. But less spans could break your traces, do the client side tracing is not working because of this.
OK,I see, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
@wu-sheng
> Yes, but span doesn't matter for SkyWalking, especially at the storage level.
**agent.sample_n_per_3_secs** config cannot measure network flow accuracy
Even **agent.sample_n_per_3_secs** is numeric small , but the whole network flow has been numeric big.
The more spans, the high network flow.
So I think agent.config need a new config **agent.spans_n_per_3_secs**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6061:
URL: https://github.com/apache/skywalking/issues/6061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6061: [javaagent] agent.sample_n_per_3_secs config stands for TraceSegment?
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6061:
URL: https://github.com/apache/skywalking/issues/6061#issuecomment-749901125
@wu-sheng
>Yes, but span doesn't matter for SkyWalking, especially at the storage level.
**agent.sample_n_per_3_secs** config cannot measure network flow accuracy
Even **agent.sample_n_per_3_secs** is numeric small , but the whole network flow could be numeric big.
The more spans, the high network flow.
So I would think agent.config need a new config **agent.spans_n_per_3_secs**
Network flow means javaagent trace data to collector, As this would influence app.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org