You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Bolke de Bruin <bd...@gmail.com> on 2019/08/21 19:40:17 UTC
Review Request 71344: Use fulltext indices for dsl search
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71344/
-----------------------------------------------------------
Review request for atlas and Nixon Rodrigues.
Bugs: https://issues.apache.org/jira/browse/ATLAS-3384
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3384
Repository: atlas
Description
-------
Per janusgraph documentation https://docs.janusgraph.org/latest/index-parameters.html strings
are indexed as text by default. Atlas uses string search which is suboptimal and leads to
significant performance loss.
This switches to use fulltext predicates which give a significant speedup.
Diffs
-----
repository/src/main/java/org/apache/atlas/query/GremlinClause.java ca8419a8c
Diff: https://reviews.apache.org/r/71344/diff/1/
Testing
-------
Tested in prod with Solr/Hbase non embedded
Thanks,
Bolke de Bruin
Re: Review Request 71344: Use fulltext indices for dsl search
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71344/#review217571
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Aug. 31, 2019, 8:21 p.m., Bolke de Bruin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71344/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2019, 8:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Nixon Rodrigues.
>
>
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3384
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3384
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Per janusgraph documentation https://docs.janusgraph.org/latest/index-parameters.html strings
> are indexed as text by default. Atlas uses string search which is suboptimal and leads to
> significant performance loss.
>
> This switches to use fulltext predicates which give a significant speedup.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java ca8419a8c
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java e64a89436
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java b73d42716
>
>
> Diff: https://reviews.apache.org/r/71344/diff/3/
>
>
> Testing
> -------
>
> Tested in prod with Solr/Hbase non embedded
>
>
> Thanks,
>
> Bolke de Bruin
>
>
Re: Review Request 71344: Use fulltext indices for dsl search
Posted by Bolke de Bruin <bd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71344/
-----------------------------------------------------------
(Updated Aug. 31, 2019, 8:21 p.m.)
Review request for atlas, Ashutosh Mestry and Nixon Rodrigues.
Changes
-------
This select the right predicate based on the specified index. This was required after merging of ATLAS-3370
Bugs: https://issues.apache.org/jira/browse/ATLAS-3384
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3384
Repository: atlas
Description
-------
Per janusgraph documentation https://docs.janusgraph.org/latest/index-parameters.html strings
are indexed as text by default. Atlas uses string search which is suboptimal and leads to
significant performance loss.
This switches to use fulltext predicates which give a significant speedup.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/GremlinClause.java ca8419a8c
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java e64a89436
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java b73d42716
Diff: https://reviews.apache.org/r/71344/diff/3/
Changes: https://reviews.apache.org/r/71344/diff/2-3/
Testing
-------
Tested in prod with Solr/Hbase non embedded
Thanks,
Bolke de Bruin
Re: Review Request 71344: Use fulltext indices for dsl search
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71344/#review217446
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Aug. 22, 2019, 3:52 a.m., Bolke de Bruin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71344/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2019, 3:52 a.m.)
>
>
> Review request for atlas and Nixon Rodrigues.
>
>
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3384
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3384
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Per janusgraph documentation https://docs.janusgraph.org/latest/index-parameters.html strings
> are indexed as text by default. Atlas uses string search which is suboptimal and leads to
> significant performance loss.
>
> This switches to use fulltext predicates which give a significant speedup.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java ca8419a8c
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 568667054
>
>
> Diff: https://reviews.apache.org/r/71344/diff/2/
>
>
> Testing
> -------
>
> Tested in prod with Solr/Hbase non embedded
>
>
> Thanks,
>
> Bolke de Bruin
>
>
Re: Review Request 71344: Use fulltext indices for dsl search
Posted by Bolke de Bruin <bd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71344/
-----------------------------------------------------------
(Updated Aug. 22, 2019, 3:52 a.m.)
Review request for atlas and Nixon Rodrigues.
Changes
-------
fix test
Bugs: https://issues.apache.org/jira/browse/ATLAS-3384
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3384
Repository: atlas
Description
-------
Per janusgraph documentation https://docs.janusgraph.org/latest/index-parameters.html strings
are indexed as text by default. Atlas uses string search which is suboptimal and leads to
significant performance loss.
This switches to use fulltext predicates which give a significant speedup.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/GremlinClause.java ca8419a8c
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 568667054
Diff: https://reviews.apache.org/r/71344/diff/2/
Changes: https://reviews.apache.org/r/71344/diff/1-2/
Testing
-------
Tested in prod with Solr/Hbase non embedded
Thanks,
Bolke de Bruin