You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/16 01:54:35 UTC
Re: Review Request 41782: Wire up the rotating container logger
module and tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 4:54 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Change module flags to reflect the `logrotate` implementation.
Summary (updated)
-----------------
Wire up the rotating container logger module and tests.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
Wire up the rotating container logger module and tests.
Diffs (updated)
-----
src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
src/tests/module.hpp 49a9203fbbef013a47367c1912c6b642e8b6bd5c
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
Diff: https://reviews.apache.org/r/41782/diff/
Testing
-------
Note: Some of the files added to the makefile are created in the next review.
Thanks,
Joseph Wu
Re: Review Request 41782: Logger Module: Wire up the rotating
container logger module and test.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:41 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Rename from "rotate" to "logrotate".
Summary (updated)
-----------------
Logger Module: Wire up the rotating container logger module and test.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
Creates a new binary "mesos-rotate-logger" for use by the non-default "Rotating" ContainerLogger module.
Adds the RotatingContainerLogger to the test module configuration.
Diffs (updated)
-----
src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53
src/tests/module.hpp 49a9203fbbef013a47367c1912c6b642e8b6bd5c
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
Diff: https://reviews.apache.org/r/41782/diff/
Testing
-------
Note: Some of the files added to the makefile are created in the next review.
Thanks,
Joseph Wu