You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2006/09/11 18:48:28 UTC
svn commit: r442253 - in /tapestry/tapestry5/tapestry-core/trunk/src:
main/java/org/apache/tapestry/internal/test/
test/java/org/apache/tapestry/internal/aspects/
test/java/org/apache/tapestry/internal/services/
Author: hlship
Date: Mon Sep 11 09:48:27 2006
New Revision: 442253
URL: http://svn.apache.org/viewvc?view=rev&rev=442253
Log:
Minor tweaks to test code.
Modified:
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/test/CodeEq.java
tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/aspects/ConcurrenceAspectTest.java
tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/services/BindingSourceImplTest.java
Modified: tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/test/CodeEq.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/test/CodeEq.java?view=diff&rev=442253&r1=442252&r2=442253
==============================================================================
--- tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/test/CodeEq.java (original)
+++ tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/test/CodeEq.java Mon Sep 11 09:48:27 2006
@@ -28,7 +28,7 @@
*/
public class CodeEq implements IArgumentMatcher
{
- private String _code;
+ private final String _code;
public CodeEq(String input)
{
Modified: tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/aspects/ConcurrenceAspectTest.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/aspects/ConcurrenceAspectTest.java?view=diff&rev=442253&r1=442252&r2=442253
==============================================================================
--- tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/aspects/ConcurrenceAspectTest.java (original)
+++ tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/aspects/ConcurrenceAspectTest.java Mon Sep 11 09:48:27 2006
@@ -26,13 +26,7 @@
@Test(sequential = true)
public class ConcurrenceAspectTest extends TestBase
{
- private ConcurrentTarget _target;
-
- @BeforeClass
- public void createTarget()
- {
- _target = new ConcurrentTarget();
- }
+ private ConcurrentTarget _target = new ConcurrentTarget();
private static final int THREAD_COUNT = 100;
Modified: tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/services/BindingSourceImplTest.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/services/BindingSourceImplTest.java?view=diff&rev=442253&r1=442252&r2=442253
==============================================================================
--- tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/services/BindingSourceImplTest.java (original)
+++ tapestry/tapestry5/tapestry-core/trunk/src/test/java/org/apache/tapestry/internal/services/BindingSourceImplTest.java Mon Sep 11 09:48:27 2006
@@ -35,7 +35,7 @@
public void expression_has_no_prefix()
{
BindingFactory factory = newBindingFactory();
- Binding b = newBinding();
+ Binding binding = newBinding();
ComponentResources component = newComponentResources();
Location l = newLocation();
@@ -43,7 +43,7 @@
String description = "descrip";
String expression = "full expression";
- train_newBinding(factory, description, component, expression, l, b);
+ train_newBinding(factory, description, component, expression, l, binding);
replay();
@@ -55,7 +55,7 @@
Binding actual = source.newBinding(description, component, defaultPrefix, expression, l);
- assertSame(actual, b);
+ assertSame(actual, binding);
verify();
}
@@ -64,7 +64,7 @@
public void expression_prefix_not_in_configuration()
{
BindingFactory factory = newBindingFactory();
- Binding b = newBinding();
+ Binding binding = newBinding();
ComponentResources component = newComponentResources();
Location l = newLocation();
@@ -72,7 +72,7 @@
String description = "descrip";
String expression = "javascript:not-a-known-prefix";
- train_newBinding(factory, description, component, expression, l, b);
+ train_newBinding(factory, description, component, expression, l, binding);
replay();
@@ -84,7 +84,7 @@
Binding actual = source.newBinding(description, component, defaultPrefix, expression, l);
- assertSame(actual, b);
+ assertSame(actual, binding);
verify();
}
@@ -93,7 +93,7 @@
public void known_prefix()
{
BindingFactory factory = newBindingFactory();
- Binding b = newBinding();
+ Binding binding = newBinding();
ComponentResources component = newComponentResources();
Location l = newLocation();
@@ -101,7 +101,7 @@
String description = "descrip";
// The "prop:" prefix is stripped off ...
- train_newBinding(factory, description, component, "myproperty", l, b);
+ train_newBinding(factory, description, component, "myproperty", l, binding);
replay();
@@ -118,7 +118,7 @@
"prop:myproperty",
l);
- assertSame(actual, b);
+ assertSame(actual, binding);
verify();
}