You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@predictionio.apache.org by shimamoto <gi...@git.apache.org> on 2017/06/27 07:33:10 UTC

[GitHub] incubator-predictionio pull request #400: [PIO-97] Fixes examples of the off...

GitHub user shimamoto opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/400

    [PIO-97] Fixes examples of the official templates for v0.11.0-incubating

    The goal of this PR is to clean up the following examples under `examples`:
    
    * scala-parallel-classification
    * scala-parallel-ecommercerecommendation
    * scala-parallel-recommendation
    * scala-parallel-similarproduct
    
    Here is part and parcel of the fix.
    
    * rename package
    * update for v0.11.0-incubating
    * bump the same version as the default
    
    As for documentation, I will handle it in another PR right after this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shimamoto/incubator-predictionio PIO-97_cleanup-examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #400
    
----
commit fe00530d50156a06add2ef055582b695b4b8cb83
Author: shimamoto <sh...@apache.org>
Date:   2017-06-20T10:43:04Z

    [PIO-97] Fixes examples of the official templates for v0.11.0-incubating.
    
    s

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #400: [PIO-97] Fixes examples of the official t...

Posted by shimamoto <gi...@git.apache.org>.

Github user shimamoto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/400
  
    We ( @takezoe helped me ) confirmed everything works. Unless we hear from you to the contrary, we will merge this next week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #400: [PIO-97] Fixes examples of the official t...

Posted by dszeto <gi...@git.apache.org>.

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/400
  
    LGTM. Please feel free to merge once it's reviewed by one of us (in this case, @takezoe).
    
    Thanks @shimamoto !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #400: [PIO-97] Fixes examples of the official t...

Posted by takezoe <gi...@git.apache.org>.

Github user takezoe commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/400
  
    @shimamoto I tested all examples and worked fine. 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #400: [PIO-97] Fixes examples of the off...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---