You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/01 09:58:23 UTC

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #507: [IOTDB-282] add "show version"

LeiRui commented on a change in pull request #507: [IOTDB-282] add "show version"
URL: https://github.com/apache/incubator-iotdb/pull/507#discussion_r341511964
 
 

 ##########
 File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java
 ##########
 @@ -287,6 +288,10 @@ private boolean executeSQL(String sql) throws TException, SQLException {
         resultSet = databaseMetaData.getNodes(Constant.COUNT_NODES, path, null, null, level);
         return true;
       }
+    } else if(sqlToLowerCase.startsWith(SHOW_VERSION_COMMAND_LOWERCASE)) {
 
 Review comment:
   startWith? So if I query "show version xxxxxx", it can also run successfully. Is that right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services