[GitHub] [maven] kwin commented on a change in pull request #191: [MNG-5180] - Versioning's snapshot version list is not included in metadata merge

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #191:
URL: https://github.com/apache/maven/pull/191#discussion_r811630139



##########
File path: maven-repository-metadata/src/main/mdo/metadata.mdo
##########
@@ -202,6 +202,30 @@ under the License.
                         changed = true;
                     }
                 }
+
+                for ( SnapshotVersion snapshotVersion : versioning.getSnapshotVersions() )
+                {
+                    boolean exists = false;
+
+                    for ( SnapshotVersion sv : v.getSnapshotVersions() )
+                    {
+                        if ( java.util.Objects.equals( snapshotVersion.getClassifier(), sv.getClassifier() ) &&
+                             java.util.Objects.equals( snapshotVersion.getExtension(), sv.getExtension() ) &&
+                             java.util.Objects.equals( snapshotVersion.getUpdated(), sv.getUpdated() ) &&

Review comment:
       This is not correct, as only classifier, extension and version act as key. The updated may actually differ but the should not lead to duplicate keys.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org