You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/01 07:18:33 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23896: Refactor `ConvertYamlConfigurationHandler`
Qianyi951015 opened a new pull request, #23896:
URL: https://github.com/apache/shardingsphere/pull/23896
For #23854.
Changes proposed in this pull request:
- Replace `ConvertYamlConfigurationHandler` with `ConvertYamlConfigurationExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23896: Refactor `ConvertYamlConfigurationHandler`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #23896:
URL: https://github.com/apache/shardingsphere/pull/23896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23896: Refactor `ConvertYamlConfigurationHandler`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23896:
URL: https://github.com/apache/shardingsphere/pull/23896#issuecomment-1411602448
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23896](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af0633d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/991e96a08e3898ca112cfcd0a222c791d82a2d1c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (991e96a) will **increase** coverage by `0.01%`.
> The diff coverage is `67.85%`.
> :exclamation: Current head af0633d differs from pull request most recent head b4ca270. Consider uploading reports for the commit b4ca270 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23896 +/- ##
============================================
+ Coverage 50.17% 50.19% +0.01%
- Complexity 1570 1571 +1
============================================
Files 3247 3247
Lines 53455 53480 +25
Branches 9795 9799 +4
============================================
+ Hits 26819 26842 +23
+ Misses 24279 24278 -1
- Partials 2357 2360 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L3J1bGUvRGF0YWJhc2VEaXNjb3ZlcnlSdWxlLmphdmE=) | `64.10% <0.00%> (ø)` | |
| [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L3Byb3ZpZGVyL29wZW5nYXVzcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3Zlcnkvb3BlbmdhdXNzL09wZW5HYXVzc05vcm1hbFJlcGxpY2F0aW9uRGF0YWJhc2VEaXNjb3ZlcnlQcm92aWRlckFsZ29yaXRobS5qYXZh) | `19.04% <0.00%> (-2.01%)` | :arrow_down: |
| [...here/mask/algorithm/MaskAlgorithmPropsChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9NYXNrQWxnb3JpdGhtUHJvcHNDaGVja2VyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...e/mode/metadata/storage/StorageNodeDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3N0b3JhZ2UvU3RvcmFnZU5vZGVEYXRhU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...tor/subscriber/ConfigurationChangedSubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3Ivc3Vic2NyaWJlci9Db25maWd1cmF0aW9uQ2hhbmdlZFN1YnNjcmliZXIuamF2YQ==) | `79.41% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `70.73% <ø> (-0.70%)` | :arrow_down: |
| [.../ShowStatusFromReadwriteSplittingRulesHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93U3RhdHVzRnJvbVJlYWR3cml0ZVNwbGl0dGluZ1J1bGVzSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...iteSplittingStorageUnitStatusStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9BbHRlclJlYWR3cml0ZVNwbGl0dGluZ1N0b3JhZ2VVbml0U3RhdHVzU3RhdGVtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dbdiscovery/algorithm/DatabaseDiscoveryEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2FsZ29yaXRobS9EYXRhYmFzZURpc2NvdmVyeUVuZ2luZS5qYXZh) | `35.00% <44.44%> (+2.50%)` | :arrow_up: |
| [...pe/MGRMySQLDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L3Byb3ZpZGVyL215c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9teXNxbC90eXBlL01HUk15U1FMRGF0YWJhc2VEaXNjb3ZlcnlQcm92aWRlckFsZ29yaXRobS5qYXZh) | `53.62% <50.00%> (-0.11%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/23896?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org