You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/10 13:09:54 UTC

[GitHub] [rocketmq] Git-Yang opened a new pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Git-Yang opened a new pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478


   ## What is the purpose of the change
   - Optimize the problem of delayed message delivery duplication.
   
   ## Brief changelog
   
   #3473 
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965562400


   
   [![Coverage Status](https://coveralls.io/builds/44502521/badge)](https://coveralls.io/builds/44502521)
   
   Coverage increased (+0.02%) to 55.114% when pulling **81311726ef8e38df1ef65d5d88b63060528ec3b5 on Git-Yang:schedule_duplicate** into **87b0be00012dff86727766081d4243eeee280699 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-1017285360


   > > 1. After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
   > > 2. First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called
   > 
   > When shutdown is called, will the method `deliverExecutorService.schedule()` throw exception??
   
   Right


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-1017572782


   Included in PR https://github.com/apache/rocketmq/pull/3478 , merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965562400


   
   [![Coverage Status](https://coveralls.io/builds/44168766/badge)](https://coveralls.io/builds/44168766)
   
   Coverage increased (+0.009%) to 54.568% when pulling **fd69104b11fc795f50ebd0d0dd00831e650eddfb on Git-Yang:schedule_duplicate** into **b35f3e4459e8cf32116bb15133aaa27d5ff63cfb on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] XiaoyiPeng commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
XiaoyiPeng commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-979853955


   Looks Good To Me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang closed pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang closed pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] HScarb commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
HScarb commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965184822


   persist delay message offset table after shutting down, LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] HScarb commented on a change in pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
HScarb commented on a change in pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#discussion_r746660973



##########
File path: store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -317,7 +318,7 @@ public void executeOnTimeup() {
                         long nextOffset = offset;
                         int i = 0;
                         ConsumeQueueExt.CqExtUnit cqExtUnit = new ConsumeQueueExt.CqExtUnit();
-                        for (; i < bufferCQ.getSize(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {
+                        for (; i < bufferCQ.getSize() && isStarted(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {

Review comment:
       I see




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965562975


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3478](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8131172) into [develop](https://codecov.io/gh/apache/rocketmq/commit/87b0be00012dff86727766081d4243eeee280699?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87b0be0) will **increase** coverage by `0.04%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3478/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3478      +/-   ##
   =============================================
   + Coverage      48.75%   48.80%   +0.04%     
   - Complexity      4649     4650       +1     
   =============================================
     Files            555      555              
     Lines          36733    36738       +5     
     Branches        4838     4838              
   =============================================
   + Hits           17911    17931      +20     
   + Misses         16576    16568       -8     
   + Partials        2246     2239       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ocketmq/store/schedule/ScheduleMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3NjaGVkdWxlL1NjaGVkdWxlTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `73.55% <60.00%> (-0.29%)` | :arrow_down: |
   | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `68.51% <0.00%> (-1.04%)` | :arrow_down: |
   | [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `70.95% <0.00%> (-0.34%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `56.04% <0.00%> (-0.20%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | |
   | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `46.56% <0.00%> (+0.12%)` | :arrow_up: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `30.16% <0.00%> (+0.65%)` | :arrow_up: |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `60.93% <0.00%> (+1.86%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87b0be0...8131172](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang commented on a change in pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on a change in pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#discussion_r746616707



##########
File path: store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -317,7 +318,7 @@ public void executeOnTimeup() {
                         long nextOffset = offset;
                         int i = 0;
                         ConsumeQueueExt.CqExtUnit cqExtUnit = new ConsumeQueueExt.CqExtUnit();
-                        for (; i < bufferCQ.getSize(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {
+                        for (; i < bufferCQ.getSize() && isStarted(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {

Review comment:
       When we close the service, we cannot guarantee that it has been executed in this for loop.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965983331


   ### Test Results
   - Before optimization
      - First step
         - 1w messages are sent through the script, and each message generates a unique self-increasing Key (0~9999)
         - After the message is sent, the delayed message is still being delivered, and the broker service is restarted at this time.
      - Second step
         - Detect whether the message is lost or repeated according to the unique self-increment key.
        - The test result is that no messages are lost and there are 7395 message duplications.
   ![image](https://user-images.githubusercontent.com/30995057/141237048-479da44b-6102-41b0-a507-82c9e2214e7f.png)
   ![image](https://user-images.githubusercontent.com/30995057/141237327-ceca785d-2930-4f81-8e27-8f1e0bb75edd.png)
   - After optimization
      - Repeat the above steps
      - The test result is no data loss, no data duplication.
   ![image](https://user-images.githubusercontent.com/30995057/141237606-af69869e-5e94-48ad-a4ba-69c683041f7c.png)
   ![image](https://user-images.githubusercontent.com/30995057/141237629-e61c8b71-df32-4583-8c24-2546d58f213c.png)
      - Strengthen the testing process
         - 100w messages are sent through the script, and each message generates a unique self-increasing Key (0~999999)
         - The message delivery process restarts the service multiple times.
         - The test result is no data loss, no data duplication.
   ![image](https://user-images.githubusercontent.com/30995057/141237713-383a051b-d5fe-4c8c-b635-2340d8ce052e.png)
   ![image](https://user-images.githubusercontent.com/30995057/141237721-5027c499-e98d-4d21-bae0-99aa57e06bc9.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] HScarb commented on a change in pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
HScarb commented on a change in pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#discussion_r746612812



##########
File path: store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -317,7 +318,7 @@ public void executeOnTimeup() {
                         long nextOffset = offset;
                         int i = 0;
                         ConsumeQueueExt.CqExtUnit cqExtUnit = new ConsumeQueueExt.CqExtUnit();
-                        for (; i < bufferCQ.getSize(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {
+                        for (; i < bufferCQ.getSize() && isStarted(); i += ConsumeQueue.CQ_STORE_UNIT_SIZE) {

Review comment:
       `executeOnTimeup()` method will only invoke in `run()` method, which already has the condition of `isStarted()`, so why add a `isStarted()` here
   https://github.com/apache/rocketmq/pull/3478/files#diff-350d772aa64ef5e5f5012863595bc2e9d35c731fbba75a81b823cf00b1a2d593R281-R282




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Git-Yang commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965293850


   1. After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
   2. First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] XiaoyiPeng edited a comment on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
XiaoyiPeng edited a comment on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-979853955


   Looks Good To Me. I have closed the issue #3541 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] MatrixHB commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
MatrixHB commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-1016174571


   > 1. After calling shutdown, wait for the execution of the thread to complete. At this time, it is forbidden to submit a new thread.
   > 2. First updateOffset and then execute schedule to avoid the inability to execute updateOffset after shutdown is called
   
   When shutdown is called, will the method `deliverExecutorService.schedule()` throw exception??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] HScarb edited a comment on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
HScarb edited a comment on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965184822


   persist delay message offset table after shutting down, and check the offset successfully loaded when start delivering delay messages


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter commented on pull request #3478: [ISSUE #3473] Optimize the problem of delayed message delivery duplication

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3478:
URL: https://github.com/apache/rocketmq/pull/3478#issuecomment-965562975


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3478](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd69104) into [develop](https://codecov.io/gh/apache/rocketmq/commit/b35f3e4459e8cf32116bb15133aaa27d5ff63cfb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b35f3e4) will **decrease** coverage by `0.51%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3478/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3478      +/-   ##
   =============================================
   - Coverage      48.87%   48.35%   -0.52%     
   - Complexity      3235     4612    +1377     
   =============================================
     Files            421      555     +134     
     Lines          26505    36729   +10224     
     Branches        3503     4839    +1336     
   =============================================
   + Hits           12953    17760    +4807     
   - Misses         11899    16732    +4833     
   - Partials        1653     2237     +584     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ocketmq/store/schedule/ScheduleMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3NjaGVkdWxlL1NjaGVkdWxlTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `73.55% <60.00%> (-0.29%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `44.77% <0.00%> (-1.50%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `28.85% <0.00%> (-0.66%)` | :arrow_down: |
   | [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `71.28% <0.00%> (-0.34%)` | :arrow_down: |
   | [...pache/rocketmq/test/util/DuplicateMessageInfo.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL0R1cGxpY2F0ZU1lc3NhZ2VJbmZvLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...tmq/client/impl/consumer/AssignedMessageQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Bc3NpZ25lZE1lc3NhZ2VRdWV1ZS5qYXZh) | `61.66% <0.00%> (ø)` | |
   | [.../producer/selector/SelectMessageQueueByRandom.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvc2VsZWN0b3IvU2VsZWN0TWVzc2FnZVF1ZXVlQnlSYW5kb20uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../java/org/apache/rocketmq/test/util/TestUtils.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1Rlc3RVdGlscy5qYXZh) | `37.50% <0.00%> (ø)` | |
   | [...pache/rocketmq/test/client/mq/MQAsyncProducer.java](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvbXEvTVFBc3luY1Byb2R1Y2VyLmphdmE=) | `73.33% <0.00%> (ø)` | |
   | ... and [132 more](https://codecov.io/gh/apache/rocketmq/pull/3478/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b35f3e4...fd69104](https://codecov.io/gh/apache/rocketmq/pull/3478?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org