[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42193: [SPARK-44432][SS][CONNECT] Terminate streaming queries when a session times out in Spark Connect

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42193:
URL: https://github.com/apache/spark/pull/42193#discussion_r1277186241


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/artifact/SparkConnectArtifactManager.scala:
##########
@@ -183,6 +183,9 @@ class SparkConnectArtifactManager(sessionHolder: SessionHolder) extends Logging
 
     // Clean up artifacts folder
     FileUtils.deleteDirectory(artifactPath.toFile)
+
+    // Clean up running queries
+    SparkConnectService.streamingSessionManager.cleanupRunningQueries(sessionHolder)

Review Comment:
   I actually think it has to be placed under `expireSession`. This class is really all about the artifacts you add, and strning query cleanup is irrelevant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org