[jira] [Commented] (CAMEL-10273) [Jetty] missing jmx object if custom thread pool is used

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440959#comment-15440959 ] 

ASF GitHub Bot commented on CAMEL-10273:
----------------------------------------

GitHub user paoloantinori opened a pull request:

    https://github.com/apache/camel/pull/1145

    CAMEL-10273 - Jetty. Fixes jmx for custom ThreadPools

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paoloantinori/camel CAMEL-10273

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1145
    
----
commit f70e1e30e397368e97142530dfc03cb0fcda1498
Author: Paolo Antinori <pa...@redhat.com>
Date:   2016-08-26T16:00:49Z

    CAMEL-10273 - Jetty. Fixes jmx for custom ThreadPools

----


> [Jetty] missing jmx object if custom thread pool is used
> --------------------------------------------------------
>
>                 Key: CAMEL-10273
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10273
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-jetty
>    Affects Versions: 2.17.3
>            Reporter: Paolo Antinori
>            Priority: Minor
>
> If a custom configuration for the ThreadPool is passed, the correspondent JMX object is not published.
> The issue here is that enableJmx(), https://github.com/apache/camel/blob/camel-2.17.3/components/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/JettyHttpComponent.java#L314
> that adds the mbeans listeners is called only after setThread https://github.com/apache/camel/blob/camel-2.17.3/components/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/JettyHttpComponent.java#L1177 method, so this explains how come the threadpool is not exposed on JMX.
> I've put a simple PR that just adds a check for {{enableJmx}} flag at component level, but I wonder if I should make it smarter to take in account possible settings only at Endpoint level or instead if we should remove it the flag per Endpoint altogether.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)