[GitHub] [incubator-uniffle] zuston commented on pull request #775: [#757] feat(server): separate flush thread pools for different storage types

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on PR #775:
URL: https://github.com/apache/incubator-uniffle/pull/775#issuecomment-1491839932

   The design looks not clear, the dependencies are complex. I think it should refactor like following steps
   1. Introducing the eventHandler like this PR does and using a queue in here. But I hope it should do more, including pushing events directly to this queue rather than using the `processEventThread`
   2. Remove the pending queue or unify to eventHandler. If using the latter, the multiple priority queues should be introduced in eventHandler
   
   Plz let me know If I'm wrong. 
   
   cc @jerqi I remember you want to remove the pending queue. How about doing this in this PR? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org