You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/28 01:49:58 UTC
[kudu-CR] [tserver] --scanner max wait ms is a run-time flag
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16669
Change subject: [tserver] --scanner_max_wait_ms is a run-time flag
......................................................................
[tserver] --scanner_max_wait_ms is a run-time flag
This patch marks --scanner_max_wait_ms flag with the 'runtime' tag
to reflect its de facto behavior. I also did a minor clean-up of
the related code.
Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
---
M src/kudu/consensus/time_manager.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 34 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/16669/1
--
To view, visit http://gerrit.cloudera.org:8080/16669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Gerrit-Change-Number: 16669
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tserver] --scanner max wait ms is a run-time flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16669 )
Change subject: [tserver] --scanner_max_wait_ms is a run-time flag
......................................................................
[tserver] --scanner_max_wait_ms is a run-time flag
This patch marks --scanner_max_wait_ms flag with the 'runtime' tag
to reflect its de facto behavior. I also did a minor clean-up of
the related code.
Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Reviewed-on: http://gerrit.cloudera.org:8080/16669
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/consensus/time_manager.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 34 insertions(+), 27 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Gerrit-Change-Number: 16669
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tserver] --scanner max wait ms is a run-time flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16669 )
Change subject: [tserver] --scanner_max_wait_ms is a run-time flag
......................................................................
Patch Set 1: Verified+1
unrelated test failure in TsTabletManagerITest.TestTableStats
--
To view, visit http://gerrit.cloudera.org:8080/16669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Gerrit-Change-Number: 16669
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Oct 2020 03:53:18 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] --scanner max wait ms is a run-time flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tserver] --scanner_max_wait_ms is a run-time flag
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Gerrit-Change-Number: 16669
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tserver] --scanner max wait ms is a run-time flag
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16669 )
Change subject: [tserver] --scanner_max_wait_ms is a run-time flag
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5907571db5de76446c5ce04ca64da8e95328087d
Gerrit-Change-Number: 16669
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Oct 2020 05:25:44 +0000
Gerrit-HasComments: No