[GitHub] [accumulo] AlbertWhitlock commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade

[GitBox <gi...@apache.org>]

AlbertWhitlock commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r964045766


##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##########
@@ -18,73 +18,71 @@
     under the License.
 
 -->
-    <div id="navbar" class="navbar navbar-inverse navbar-fixed-top">
-      <div class="container-fluid">
-        <!-- toggle -->
-        <div class="navbar-header">
-          <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#nav-items" aria-expanded="false">
-            <span class="sr-only">Toggle navigation</span>
-            <span class="icon-bar"></span>
-            <span class="icon-bar"></span>
-            <span class="icon-bar"></span>
-          </button>
-          <a class="navbar-brand" id="headertitle" href="/">
-            <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
-            ${instance_name}
-          </a>
-        </div>
-        <!-- Nav links -->
-        <div class="collapse navbar-collapse" id="nav-items">
-          <ul class="nav navbar-nav navbar-right">
-            <li class="dropdown">
-              <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false"><span id="statusNotification" class="icon-dot normal"></span>&nbsp;Servers&nbsp;<span class="caret"></span>
-              </a>
-              <ul class="dropdown-menu">
-                <li><a href="/manager"><span id="managerStatusNotification" class="icon-dot normal"></span>&nbsp;Manager&nbsp;Server&nbsp;</a></li>
-                <li><a href="/tservers"><span id="serverStatusNotification" class="icon-dot normal"></span>&nbsp;Tablet&nbsp;Servers&nbsp;</a></li>
-                <li><a href="/gc"><span id="gcStatusNotification" class="icon-dot normal"></span>&nbsp;Garbage&nbsp;collector&nbsp;</a></li>
-              </ul>
-            </li>
-            <li><a href="/tables">Tables</a></li>
-            <li class="dropdown">
-              <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
-                Activity <span class="caret"></span>
-              </a>
-              <ul class="dropdown-menu">
-                <li><a href="/compactions">Active&nbsp;Compactions</a></li>
-                <li><a href="/scans">Active&nbsp;Scans</a></li>
-                <li><a href="/bulkImports">Bulk&nbsp;Imports</a></li>
-                <li><a href="/ec">External&nbsp;Compactions</a></li>
-                <li><a href="/replication">Replication</a></li>
-              </ul>
-            </li>
-            <li class="dropdown">
-              <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Debug&nbsp;<span id="errorsNotification" class="badge"></span><span class="caret"></span>
-              </a>
-              <ul class="dropdown-menu">
-                <li><a href="/log">Recent&nbsp;Logs&nbsp;<span id="recentLogsNotifications" class="badge"></span></a></li>
-                <li><a href="/problems">Table&nbsp;Problems&nbsp;<span id="tableProblemsNotifications" class="badge"></span></a></li>
-              </ul>
-            </li>
-            <li class="dropdown">
-              <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
-                REST <span class="caret"></span>
-              </a>
-              <ul class="dropdown-menu">
-                <li><a href="/rest/xml">XML Summary</a></li>
-                <li><a href="/rest/json">JSON Summary</a></li>
-              </ul>
-            </li>
-            <li class="dropdown">
-              <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
-                <span class="glyphicon glyphicon-option-vertical"></span>
-              </a>
-              <ul class="dropdown-menu">
-                <li><a class="auto-refresh" style="cursor:pointer">Auto-Refresh</a></li>
-                <li><a data-toggle="modal" href="#aboutModal">About</a></li>
-              </ul>
-            </li>
-          </ul>
-        </div>
-      </div>
+<nav class="navbar navbar-expand-lg navbar-dark bg-dark">
+  <div class="container-fluid">
+    <a class="navbar-brand" id="headertitle" href="/">
+                <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
+                uno

Review Comment:
   Changed it back to ${instance_name}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org