You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by markgrover <gi...@git.apache.org> on 2016/01/27 00:03:28 UTC

[GitHub] spark pull request: [WIP] [SPARK-12177] [STREAMING] Update KafkaDS...

Github user markgrover commented on the pull request:

    https://github.com/apache/spark/pull/10681#issuecomment-175284165
  
    Hi @nikit-os, I have made a bunch of more changes in my personal branch at https://github.com/markgrover/spark/tree/kafka09-integration and some WIP changes for the python implementation at https://github.com/markgrover/spark/tree/kafka09-integration-python.
    
    For now, I want to drive forward the Java/Scala and get feedback from the community. To make that easier, I would love to file a separate pull request that will be based off your original PR (i.e. this pull request). My desire is not take credit away from you, in fact, I will keep the history in tact, and explicitly mention that you have contributed a good chunk of this work but I don't want the logistical overhead of having to issue you a pull request to your branch, every time I want to update this pull request.
    
    Would it be ok if I create a new pull request, that's a super set of, and supersedes this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org