You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/04/08 16:15:19 UTC

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/#review127786
-----------------------------------------------------------


Fix it, then Ship it!




Mind adding the description and do tests in repetition?


src/tests/master_tests.cpp (line 745)
<https://reviews.apache.org/r/43514/#comment191172>

    I believe you do settle in order to make sure the container is destroyed. Mind writing a comment?
    
    Also, I think you can resume the clock right after advancing.


- Alexander Rukletsov


On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43514/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4164
>     https://issues.apache.org/jira/browse/MESOS-4164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up MasterTest.RecoverResources.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43514/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>