You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2012/07/13 09:12:56 UTC

Review Request: CS-15572:StartIndex handled incorrectly when switching between the various "Filter by" options while listing ISOs in the UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5928/
-----------------------------------------------------------

Review request for cloudstack, Saksham Srivastava and Brian Federle.


Description
-------

Go to templates tab and select ISO's from the drop down. Add at least 21-25 ISO's and check if first 20 of them they have been listed on the page. Note that the default capacity of one page is 20 .So all the other ISO's will start getting listed from the next page,by scrolling down.
2) Now to check the ISO's added by the user , go to the "mine" filter .
Expected Result - He should be able to see all the ISO's which he added .
Actual Result - He is only able to see those ISO's listed on the first page. Rest of them are truncated from the entire list.

Also on navigating back to "all" filter it displays only the ISO's on the first page and truncates the remaining ones.

It happens due to incorrect handling of the startIndex parameter whenever a navigation occurs by selecting the various filters. 

The problem was basically with the page variable defined in the listView.js file which seems to behave like a static variable as its value keeps on incrementing when switching between pages through filters. The need is to make the page variable set to the initial value to get the desired behavior . I have added a Jquery function to handle this requirement


This addresses bug CS-15572.


Diffs
-----

  ui/scripts/ui/widgets/listView.js b01d01e 

Diff: https://reviews.apache.org/r/5928/diff/


Testing
-------

Verfied on saksham's cloudstack set up where he was able to fetch the entire list of 30 ISO's while switching between the panels when selecting the different Filters.


Thanks,

Pranav Saxena