You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/22 16:22:58 UTC

[GitHub] [nifi] mattyb149 commented on a change in pull request #4350: NIFI-6934 In PutDatabaseRecord added Postgres UPSERT support

mattyb149 commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r443679370



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -156,7 +162,7 @@
                     + "FlowFile. The 'Use statement.type Attribute' option is the only one that allows the 'SQL' statement type. If 'SQL' is specified, the value of the field specified by the "
                     + "'Field Containing SQL' property is expected to be a valid SQL statement on the target database, and will be executed as-is.")

Review comment:
       We should add some doc here explaining that some Statement Type values may not be supported depending on the value of the Database Type property, and can even include an example ("For example, UPSERT statements are not supported by Oracle" or something like that) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org