You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/30 08:08:53 UTC
Review Request 68566: Updated Python dependencies for Python 3.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68566/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.
Bugs: MESOS-9186
https://issues.apache.org/jira/browse/MESOS-9186
Repository: mesos
Description
-------
Fixes issues with `mesos-style.py` when editing Python files for the
Mesos CLI and Python package with Python 3.7 installed (MESOS-9186).
Diffs
-----
src/python/cli_new/pip-requirements.txt 8645912a63b22878f477e96bfa8bc95abe893f85
src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17
src/python/lib/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2
src/python/lib/tox.ini 0779fb22d1e8af2dbd17d0fb6b1c8cf3dc2e37d3
Diff: https://reviews.apache.org/r/68566/diff/1/
Testing
-------
Linted different files in the two modules.
Thanks,
Armand Grillet
Re: Review Request 68566: Updated Python dependencies for Python 3.7.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68566/#review208122
-----------------------------------------------------------
PASS: Mesos patch 68566 was successfully built and tested.
Reviews applied: `['68535', '68566']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2263/mesos-review-68566
- Mesos Reviewbot Windows
On Aug. 30, 2018, 8:08 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68566/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 8:08 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.
>
>
> Bugs: MESOS-9186
> https://issues.apache.org/jira/browse/MESOS-9186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixes issues with `mesos-style.py` when editing Python files for the
> Mesos CLI and Python package with Python 3.7 installed (MESOS-9186).
>
>
> Diffs
> -----
>
> src/python/cli_new/pip-requirements.txt 8645912a63b22878f477e96bfa8bc95abe893f85
> src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17
> src/python/lib/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2
> src/python/lib/tox.ini 0779fb22d1e8af2dbd17d0fb6b1c8cf3dc2e37d3
>
>
> Diff: https://reviews.apache.org/r/68566/diff/1/
>
>
> Testing
> -------
>
> Linted different files in the two modules.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68566: Updated Python dependencies for Python 3.7.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68566/#review208160
-----------------------------------------------------------
Ship it!
LGTM! Thanks Armand.
- Benjamin Bannier
On Aug. 30, 2018, 10:08 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68566/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 10:08 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.
>
>
> Bugs: MESOS-9186
> https://issues.apache.org/jira/browse/MESOS-9186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixes issues with `mesos-style.py` when editing Python files for the
> Mesos CLI and Python package with Python 3.7 installed (MESOS-9186).
>
>
> Diffs
> -----
>
> src/python/cli_new/pip-requirements.txt 8645912a63b22878f477e96bfa8bc95abe893f85
> src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17
> src/python/lib/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2
> src/python/lib/tox.ini 0779fb22d1e8af2dbd17d0fb6b1c8cf3dc2e37d3
>
>
> Diff: https://reviews.apache.org/r/68566/diff/2/
>
>
> Testing
> -------
>
> Linted different files in the two modules.
>
>
> Thanks,
>
> Armand Grillet
>
>