[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #130: Reduce logging overhead by holding references

[GitBox <gi...@apache.org>]

ams-tschoening commented on PR #130:
URL: https://github.com/apache/logging-log4cxx/pull/130#issuecomment-1250086257

   Doesn't work for my RAD Studio 10.2, which defaults to the legacy BCC32 compiler and targets 32 Bit Windows:
   
   ```
   [bcc32 Error] File2.cpp(13): E2209 Unable to open include file 'thread'
   [bcc32 Error] File2.cpp(15): E2141 Declaration syntax error
   [bcc32 Error] File2.cpp(18): E2316 'this_thread' is not a member of 'std'
     Full parser context
       File2.cpp(17): parsing: void printTestVarValue()
   [bcc32 Error] File2.cpp(18): E2121 Function call missing )
     Full parser context
       File2.cpp(17): parsing: void printTestVarValue()
   [bcc32 Error] File2.cpp(22): E2451 Undefined symbol 'test_var'
     Full parser context
       File2.cpp(21): parsing: void setTestVar()
   [bcc32 Error] File2.cpp(24): E2316 'this_thread' is not a member of 'std'
     Full parser context
       File2.cpp(21): parsing: void setTestVar()
   [bcc32 Error] File2.cpp(24): E2379 Statement missing ;
     Full parser context
       File2.cpp(21): parsing: void setTestVar()
   [bcc32 Error] File2.cpp(30): E2451 Undefined symbol 'test_var'
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   [bcc32 Error] File2.cpp(34): E2316 'thread' is not a member of 'std'
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   [bcc32 Error] File2.cpp(34): E2379 Statement missing ;
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   [bcc32 Error] File2.cpp(36): E2316 'this_thread' is not a member of 'std'
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   [bcc32 Error] File2.cpp(36): E2379 Statement missing ;
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   [bcc32 Error] File2.cpp(39): E2451 Undefined symbol 'th'
     Full parser context
       File2.cpp(29): parsing: int main(int,char * *)
   Failed
   Elapsed time: 00:00:00.9
   ```
   
   When adding the 64 Bit Windows target, the compiler used should be CLANG, like with your test by default, and the code successfully compiles, but doesn't link. The latter is most likely something wrong with the project setup and as said, we shouldn't care about BCC32 too much. Just use `thread_local` and deal with complains when they occur. BCC32 is VERY legacy and deprecated and Borland altogether not that widespread anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org