You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by piotrkosyoo <gi...@git.apache.org> on 2018/02/10 14:21:54 UTC
[GitHub] commons-lang pull request #313: LANG-1060: NumberUtils.isNumber assumes numb...
GitHub user piotrkosyoo opened a pull request:
https://github.com/apache/commons-lang/pull/313
LANG-1060: NumberUtils.isNumber assumes number starting with Zero
NumberUtils.isCreatable("002.345"); return false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/piotrkosOpen/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit 6001ce20ac49522cfd6f066b8a8bd29aab74abfb
Author: Piotr Kosmala <pi...@...>
Date: 2018-02-10T14:19:36Z
LANG-1060: NumberUtils.isNumber assumes number starting with Zero is
octal
----
---
[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
Thanks! 👍
---
[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...
Posted by piotrkosyoo <gi...@git.apache.org>.
Github user piotrkosyoo commented on the issue:
https://github.com/apache/commons-lang/pull/313
ok in this same issue number ?
---
[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
Sure, that is fine!
---
[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...
Posted by piotrkosyoo <gi...@git.apache.org>.
Github user piotrkosyoo commented on the issue:
https://github.com/apache/commons-lang/pull/313
No problem Sir,
Calling Number.to Float also works correctly, and I skip this point. but maybe
better is add the tests for this case?
---
[GitHub] commons-lang issue #313: LANG-1060: NumberUtils.isNumber assumes number star...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/313
A pull request with tests for the `float` case would be welcome.
---
[GitHub] commons-lang pull request #313: LANG-1060: NumberUtils.isNumber assumes numb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/313
---