[GitHub] [shardingsphere] tristaZero commented on pull request #9249: Test encrypt rule, replicaQuery rule and sharding rule all exist when do query in calcite.

[GitBox <gi...@apache.org>]

tristaZero commented on pull request #9249:
URL: https://github.com/apache/shardingsphere/pull/9249#issuecomment-773772327


   Hi @lmhmhl , 
   
   >  I have tried a lot but all failed, so this PR is just a compromise, I am in confused now, I would be very glad if u can give me some advices.
   
   I know this task is a little tricky, but that's why I want to have you taking charge of it. : ) Basically, I believe you can do better than other newbies.
   Secondly, I suppose we can get more things while doing community tasks. So please take it easy. If any confusion, we can discuss it and figure it out.
   
   I am unsure whether I got your point wholly. However, the primary blocker you met looks like the function of `ShardingSphereDataSource` (Virtual DB) and the `Map<String, DataSource>` (Actual DBs) from `conn.getDataSourceMap()`.
   
   ### Map<String, DataSource> for setting up test env
   We use all the actual data sources to prepare initial data for databases. There is unnecessary to consider `ShardingSphereDataSource`, therefore I think `initTable()` has no critical issues. Just use them to execute the corresponding initialization scrip.
   
   ### ShardingSphereDataSource for test
   After having the expected test databases, we will use `ShardingSphereDataSource` to test `logic SQLs` in UT.
   This phase's key point is to write the configuration file, which means configure logic DB, table, columns with these actual ones. Definitely, this part of the work mainly needs your deep understanding of different configurations.  If you have any questions about this one, please contact me.
   Could you figure out which one is your concern? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org