You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2015/11/12 18:30:49 UTC

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 5:30 p.m.)


Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.


Changes
-------

Actually used updated images.


Bugs: MESOS-3839
    https://issues.apache.org/jira/browse/MESOS-3839


Repository: mesos


Description
-------

Update the documentation for a fetcher cache behavior using both
source file size and mtime information.

Also:
* Remove outdated information regarding long supported fetcher cache
  support for ftp/ftps.
* Use png instead of jpeg for fetcher cache internal documentation.
  Jpeg are designed to work well for compressing photos, but produce
  artifacts for line art. Use a bitmap format instead.


Diffs (updated)
-----

  docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19 
  docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
  docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
  docs/images/fetch_components.png PRE-CREATION 
  docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
  docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
  docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
  docs/images/fetch_evict_1.png PRE-CREATION 
  docs/images/fetch_evict_2.png PRE-CREATION 
  docs/images/fetch_evict_3.png PRE-CREATION 
  docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
  docs/images/fetch_flow.png PRE-CREATION 
  docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
  docs/images/fetch_state.png PRE-CREATION 

Diff: https://reviews.apache.org/r/40136/diff/


Testing
-------

Built and served with bundled site docker container,

    % docker build support/site-docker


Thanks,

Benjamin Bannier

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

Posted by Benjamin Bannier <be...@mesosphere.io>.


> On Nov. 12, 2015, 5:49 p.m., Joseph Wu wrote:
> > Note: `post-reviews.py` doesn't quite work when uploading images.  If you download the diff, you'll notice that it's only 3 kb.
> > 
> > You have to manually generate the diff (via `git diff --binary`) and upload it to RB manually, via the menu bar widget ("Update" -> "Update Diff").

Thanks for the hand-holding Joseph. I created a ticket so we can fix this or at least track upstream's progress.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106274
-----------------------------------------------------------


On Nov. 12, 2015, 6:17 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 6:17 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
>     https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md b71d225 
>   docs/fetcher.md 8e64341 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> -------
> 
> Built and served with bundled site docker container,
> 
>     % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106274
-----------------------------------------------------------


Note: `post-reviews.py` doesn't quite work when uploading images.  If you download the diff, you'll notice that it's only 3 kb.

You have to manually generate the diff (via `git diff --binary`) and upload it to RB manually, via the menu bar widget ("Update" -> "Update Diff").

- Joseph Wu


On Nov. 12, 2015, 9:30 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 9:30 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
>     https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19 
>   docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> -------
> 
> Built and served with bundled site docker container,
> 
>     % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106273
-----------------------------------------------------------


Bad patch!

Reviews applied: [39594, 39595, 40136]

Failed command: ./support/apply-review.sh -n -r 40136

Error:
 2015-11-12 17:48:17 URL:https://reviews.apache.org/r/40136/diff/raw/ [9075/9075] -> "40136.patch" [1]
error: missing binary patch data for 'docs/images/fetch_components.png'
error: binary patch does not apply to 'docs/images/fetch_components.png'
error: docs/images/fetch_components.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_evict_1.png'
error: binary patch does not apply to 'docs/images/fetch_evict_1.png'
error: docs/images/fetch_evict_1.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_evict_2.png'
error: binary patch does not apply to 'docs/images/fetch_evict_2.png'
error: docs/images/fetch_evict_2.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_evict_3.png'
error: binary patch does not apply to 'docs/images/fetch_evict_3.png'
error: docs/images/fetch_evict_3.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_flow.png'
error: binary patch does not apply to 'docs/images/fetch_flow.png'
error: docs/images/fetch_flow.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_state.png'
error: binary patch does not apply to 'docs/images/fetch_state.png'
error: docs/images/fetch_state.png: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 12, 2015, 5:30 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
>     https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19 
>   docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> -------
> 
> Built and served with bundled site docker container,
> 
>     % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40136: Updated documentation on fetcher cache internals.

Posted by Bernd Mathiske <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106624
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 12, 2015, 12:26 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 12:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
>     https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md b71d225 
>   docs/fetcher.md 8e64341 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> -------
> 
> Built and served with bundled site docker container,
> 
>     % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40136: Updated documentation on fetcher cache internals.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 8:26 p.m.)


Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.


Changes
-------

Removed WIP tag as this is public.


Summary (updated)
-----------------

Updated documentation on fetcher cache internals.


Bugs: MESOS-3839
    https://issues.apache.org/jira/browse/MESOS-3839


Repository: mesos


Description
-------

Update the documentation for a fetcher cache behavior using both
source file size and mtime information.

Also:
* Remove outdated information regarding long supported fetcher cache
  support for ftp/ftps.
* Use png instead of jpeg for fetcher cache internal documentation.
  Jpeg are designed to work well for compressing photos, but produce
  artifacts for line art. Use a bitmap format instead.


Diffs
-----

  docs/fetcher-cache-internals.md b71d225 
  docs/fetcher.md 8e64341 
  docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
  docs/images/fetch_components.png PRE-CREATION 
  docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
  docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
  docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
  docs/images/fetch_evict_1.png PRE-CREATION 
  docs/images/fetch_evict_2.png PRE-CREATION 
  docs/images/fetch_evict_3.png PRE-CREATION 
  docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
  docs/images/fetch_flow.png PRE-CREATION 
  docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
  docs/images/fetch_state.png PRE-CREATION 

Diff: https://reviews.apache.org/r/40136/diff/


Testing
-------

Built and served with bundled site docker container,

    % docker build support/site-docker


Thanks,

Benjamin Bannier

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106326
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39594, 39595, 40136]

All tests passed.

- Mesos ReviewBot


On Nov. 12, 2015, 6:17 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 6:17 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
>     https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md b71d225 
>   docs/fetcher.md 8e64341 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> -------
> 
> Built and served with bundled site docker container,
> 
>     % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40136: WIP Updated documentation on fetcher cache internals.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 6:17 p.m.)

Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.

Changes
-------

Worked around `post-reviews.py` limitation.

It seems binary files cannot be uploaded with `post-reviews.py`, but instead one needs to manually upload the diff. I filed MESOS-3906.

Bugs: MESOS-3839
https://issues.apache.org/jira/browse/MESOS-3839

Repository: mesos

Description
-------

Update the documentation for a fetcher cache behavior using both
source file size and mtime information.

Also:
* Remove outdated information regarding long supported fetcher cache
support for ftp/ftps.
* Use png instead of jpeg for fetcher cache internal documentation.
Jpeg are designed to work well for compressing photos, but produce
artifacts for line art. Use a bitmap format instead.

Diffs (updated)
-----

docs/fetcher-cache-internals.md b71d225
docs/fetcher.md 8e64341
docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725
docs/images/fetch_components.png PRE-CREATION
docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b
docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7
docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5
docs/images/fetch_evict_1.png PRE-CREATION
docs/images/fetch_evict_2.png PRE-CREATION
docs/images/fetch_evict_3.png PRE-CREATION
docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b
docs/images/fetch_flow.png PRE-CREATION
docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e
docs/images/fetch_state.png PRE-CREATION

Diff: https://reviews.apache.org/r/40136/diff/

Testing
-------

Built and served with bundled site docker container,

% docker build support/site-docker

Thanks,

Benjamin Bannier