You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xunxunmimi5577 (via GitHub)" <gi...@apache.org> on 2023/04/02 10:20:36 UTC
[GitHub] [incubator-celeborn] xunxunmimi5577 opened a new pull request, #1402: Add a notifyLogFailed method implementation
xunxunmimi5577 opened a new pull request, #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add a notifyLogFailed method implementation in class StateMachine and a stepDown method in class HARaftServer and relative UT.
### Why are the changes needed?
https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-495?filter=allopenissues
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1402: Add a notifyLogFailed method implementation
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493602064
ping @AngersZhuuuu could you take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1402: [CELEBORN-501] Add a notifyLogFailed method implementation in StateMachine
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493726673
Title should be `[CELEBORN-495] Add a notifyLogFailed method implementation in StateMachine` ?
cc @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1402: [CELEBORN-495] Leader should step down when its metadata directory has IO exception
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1402: Add a notifyLogFailed method implementation
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493608184
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1402?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1402](https://codecov.io/gh/apache/incubator-celeborn/pull/1402?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b489114) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/61416a828d59dee01e88b4901a3850896050144b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61416a8) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 45.03% 45.01% -0.02%
==========================================
Files 164 164
Lines 10386 10393 +7
Branches 1056 1057 +1
==========================================
+ Hits 4676 4677 +1
- Misses 5370 5376 +6
Partials 340 340
```
[see 6 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1402/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1402: [CELEBORN-495] Leader should step down when its metadata directory has IO exception
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493765057
@xunxunmimi5577 Pls add more content to PR desc about this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1402: [CELEBORN-501] Add a notifyLogFailed method implementation in StateMachine
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493693219
Hi @xunxunmimi5577 , thanks for the PR! Celeborn uses jira for issue tracking, I've created a jira for this https://issues.apache.org/jira/browse/CELEBORN-501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1402: [CELEBORN-495] Leader should step down when its metadata directory has IO exception
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493873431
@xunxunmimi5577 you can use
\`\`\`
\`\`\`
for code block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] xunxunmimi5577 commented on pull request #1402: [CELEBORN-501] Add a notifyLogFailed method implementation in StateMachine
Posted by "xunxunmimi5577 (via GitHub)" <gi...@apache.org>.
xunxunmimi5577 commented on PR #1402:
URL: https://github.com/apache/incubator-celeborn/pull/1402#issuecomment-1493746887
Thanks @waitinfuture, I've actually created jira CELEBORN-495.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org