You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "SahilKang (via GitHub)" <gi...@apache.org> on 2024/03/04 10:51:05 UTC
[PR] AVRO-3954: [common-lisp] Add Common Lisp implementation [avro]
SahilKang opened a new pull request, #2784:
URL: https://github.com/apache/avro/pull/2784
## What is the purpose of the change
This integrates https://github.com/SahilKang/cl-avro
## Verifying this change
This change adds a new implementation, with its own tests. See the readme in this commit to run tests
## Documentation
The API is documented via docstrings, which are discoverable through the normal lisp repl facilities
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3954: [common-lisp] Add Common Lisp implementation [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2784:
URL: https://github.com/apache/avro/pull/2784#discussion_r1513518916
##########
lang/common-lisp/avro.asd:
##########
@@ -0,0 +1,248 @@
+;;; Copyright 2024 Google LLC
Review Comment:
I am not sure but I think this line needs to be removed if this PR will be accepted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3954: [common-lisp] Add Common Lisp implementation [avro]
Posted by "SahilKang (via GitHub)" <gi...@apache.org>.
SahilKang commented on code in PR #2784:
URL: https://github.com/apache/avro/pull/2784#discussion_r1513828293
##########
lang/common-lisp/avro.asd:
##########
@@ -0,0 +1,248 @@
+;;; Copyright 2024 Google LLC
Review Comment:
I updated the license headers to match the other implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org