You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "lokiore (via GitHub)" <gi...@apache.org> on 2023/10/12 05:12:55 UTC

[PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

lokiore opened a new pull request, #1706:
URL: https://github.com/apache/phoenix/pull/1706

   FYI @jpisaac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

Posted by "lokiore (via GitHub)" <gi...@apache.org>.
lokiore commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357469758


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);

Review Comment:
   Aaah I see....... ✌️ 



##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);

Review Comment:
   Aaah I see....... ✌️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

Posted by "lokiore (via GitHub)" <gi...@apache.org>.
lokiore commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357457963


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);

Review Comment:
   Yes, We are testing connection counts for different scenarios in LoggingConnectionLimiterIT, and these counts gets updated when we call acquire connection in CQSI's addConnection, which was not being used before as part of CQSTestImpl.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac merged PR #1706:
URL: https://github.com/apache/phoenix/pull/1706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357435647


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);
         connections.add(connection);
         super.addConnection(connection);
     }
     
     @Override
     public void removeConnection(PhoenixConnection connection) throws SQLException {
+        super.removeConnection(connection);

Review Comment:
   Same here



##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);

Review Comment:
   Was this added intentionally? Do see a similar statement below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PHOENIX-7063 Track and account garbage collected phoenix connections [phoenix]

Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357463995


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices services, ConnectionInfo in
     
     @Override
     public void addConnection(PhoenixConnection connection) throws SQLException {
+        super.addConnection(connection);

Review Comment:
   But there is already a super.addConnection(..) below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org