[jira] [Commented] (ARTEMIS-734) Message expired while being moved on the cluster bridge does not follow the address setting configuration

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506484#comment-17506484 ] 

ASF subversion and git services commented on ARTEMIS-734:
---------------------------------------------------------

Commit 1ed7cc1efcf53183abc95a08ec6f27fb1cbe36ac in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1ed7cc1 ]

ARTEMIS-3719 DLA and expiry incorrect w/temp-queue-namespace

When using a temporary queue with a `temporary-queue-namespace` the
`AddressSettings` lookup wasn't correct. This commit fixes that and
refactors `QueueImpl` a bit so that it holds a copy of its
`AddressSettings` rather than looking them up all the time. If any
relevant `AddressSettings` changes the
`HierarchicalRepositoryChangeListener` implementation will still
refresh the `QueueImpl` appropriately.

The `QueueControlImpl` was likewise changed to get the dead-letter
address and expiry address directly from the `QueueImpl` rather than
looking them up in the `AddressSettings` repository.

I modified some code that came from ARTEMIS-734, but I ran the test that
was associated with that Jira (i.e.
`o.a.a.a.t.i.c.d.ExpireWhileLoadBalanceTest`) and it passed so I think
that should be fine. There actually was no test included with the
original commit. One was added later so it's hard to say for sure it
exactly captures the original issue.


> Message expired while being moved on the cluster bridge does not follow the address setting configuration
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-734
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-734
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Clebert Suconic
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)