You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/04/12 17:18:45 UTC
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18404
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
IMPALA-10699: Patch libev to support C++17
Libev's ev++.h uses the "throw(exception)" syntax
that has been removed in c++17. This patches libev
to change this to "noexcept(false)". This is using
a patch directly from Kudu.
Testing:
- Compiled Impala with c++17 with this patch
Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
---
M buildall.sh
A source/libev/libev-4.20-patches/0001-Fix-c17-throw-statements.patch
2 files changed, 38 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/04/18404/1
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 12:59:28 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 3: Code-Review+2
Reapply +2
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 May 2022 15:35:44 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 18:04:57 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 18:03:58 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18404/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18404/1/buildall.sh@339
PS1, Line 339: ################################
> Hello Joe! I'd like to tag along in this patch to bump up KUDU_VERSION= 09a
Nevermind, I just filed https://gerrit.cloudera.org/c/18516 on top of this patch.
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 18:28:39 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
IMPALA-10699: Patch libev to support C++17
Libev's ev++.h uses the "throw(exception)" syntax
that has been removed in c++17. This patches libev
to change this to "noexcept(false)". This is using
a patch directly from Kudu.
Testing:
- Compiled Impala with c++17 with this patch
Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Reviewed-on: http://gerrit.cloudera.org:8080/18404
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>
---
M buildall.sh
A source/libev/libev-4.20-patches/0001-Fix-c17-throw-statements.patch
2 files changed, 38 insertions(+), 1 deletion(-)
Approvals:
Riza Suminto: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 3: Verified+1
This relation chain pass all test except a flaky minidump-test that is only recently fixed in IMPALA-11291.
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 May 2022 13:38:12 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 )
Change subject: IMPALA-10699: Patch libev to support C++17
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18404/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18404/1/buildall.sh@339
PS1, Line 339: export KUDU_VERSION=67ba3cae45
Hello Joe! I'd like to tag along in this patch to bump up KUDU_VERSION= 09a6c8833e.
This is the most recent Kudu upstream that contains KUDU-3351 and KUDU-3365, which is required for IMPALA-10465 work.
--
To view, visit http://gerrit.cloudera.org:8080/18404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5cba45a426c4237cb0ef7c28a806a117dfd212a
Gerrit-Change-Number: 18404
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 18:08:23 +0000
Gerrit-HasComments: Yes