You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2018/06/19 22:14:28 UTC
Review Request 67659: provide new function to test whether an explicit
expiry policy was set on a terminus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67659/
-----------------------------------------------------------
Review request for qpid, Alan Conway and Andrew Stitcher.
Bugs: PROTON-1866
https://issues.apache.org/jira/browse/PROTON-1866
Repository: qpid-proton-git
Description
-------
This allows users of proton to determine whether an explicit expiry was requested or not.
Diffs
-----
c/include/proton/terminus.h b2344c0
c/src/core/engine-internal.h b1c6123
c/src/core/engine.c 070c751
c/src/core/transport.c bfa66c1
Diff: https://reviews.apache.org/r/67659/diff/1/
Testing
-------
All tests pass.
Thanks,
Gordon Sim
Re: Review Request 67659: provide new function to test whether an
explicit expiry policy was set on a terminus
Posted by Gordon Sim <gs...@redhat.com>.
> On June 20, 2018, 12:56 p.m., Kenneth Giusti wrote:
> > c/include/proton/terminus.h
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/67659/diff/1/?file=2042627#file2042627line200>
> >
> > nit:
> >
> > since this does not change the value of *terminus can the parameter be defined as 'const pn_terminus_t *' instead?
Sure, I'll do that. (However none of the get_xxx methods take a const at present, even if they also do not alter the terminus passed in).
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67659/#review205062
-----------------------------------------------------------
On June 19, 2018, 10:14 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67659/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 10:14 p.m.)
>
>
> Review request for qpid, Alan Conway and Andrew Stitcher.
>
>
> Bugs: PROTON-1866
> https://issues.apache.org/jira/browse/PROTON-1866
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> This allows users of proton to determine whether an explicit expiry was requested or not.
>
>
> Diffs
> -----
>
> c/include/proton/terminus.h b2344c0
> c/src/core/engine-internal.h b1c6123
> c/src/core/engine.c 070c751
> c/src/core/transport.c bfa66c1
>
>
> Diff: https://reviews.apache.org/r/67659/diff/1/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 67659: provide new function to test whether an
explicit expiry policy was set on a terminus
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67659/#review205062
-----------------------------------------------------------
c/include/proton/terminus.h
Lines 200 (patched)
<https://reviews.apache.org/r/67659/#comment288014>
nit:
since this does not change the value of *terminus can the parameter be defined as 'const pn_terminus_t *' instead?
- Kenneth Giusti
On June 19, 2018, 10:14 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67659/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 10:14 p.m.)
>
>
> Review request for qpid, Alan Conway and Andrew Stitcher.
>
>
> Bugs: PROTON-1866
> https://issues.apache.org/jira/browse/PROTON-1866
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> This allows users of proton to determine whether an explicit expiry was requested or not.
>
>
> Diffs
> -----
>
> c/include/proton/terminus.h b2344c0
> c/src/core/engine-internal.h b1c6123
> c/src/core/engine.c 070c751
> c/src/core/transport.c bfa66c1
>
>
> Diff: https://reviews.apache.org/r/67659/diff/1/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 67659: provide new function to test whether an
explicit expiry policy was set on a terminus
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67659/#review205065
-----------------------------------------------------------
Ship it!
Ship It!
- Kenneth Giusti
On June 20, 2018, 1:09 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67659/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 1:09 p.m.)
>
>
> Review request for qpid, Alan Conway and Andrew Stitcher.
>
>
> Bugs: PROTON-1866
> https://issues.apache.org/jira/browse/PROTON-1866
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> This allows users of proton to determine whether an explicit expiry was requested or not.
>
>
> Diffs
> -----
>
> c/include/proton/terminus.h b2344c0
> c/src/core/engine-internal.h b1c6123
> c/src/core/engine.c 070c751
> c/src/core/transport.c bfa66c1
>
>
> Diff: https://reviews.apache.org/r/67659/diff/2/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 67659: provide new function to test whether an
explicit expiry policy was set on a terminus
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67659/
-----------------------------------------------------------
(Updated June 20, 2018, 1:09 p.m.)
Review request for qpid, Alan Conway and Andrew Stitcher.
Changes
-------
Updated to to have const pn_terminus_t* passed in to new method as requested.
Bugs: PROTON-1866
https://issues.apache.org/jira/browse/PROTON-1866
Repository: qpid-proton-git
Description
-------
This allows users of proton to determine whether an explicit expiry was requested or not.
Diffs (updated)
-----
c/include/proton/terminus.h b2344c0
c/src/core/engine-internal.h b1c6123
c/src/core/engine.c 070c751
c/src/core/transport.c bfa66c1
Diff: https://reviews.apache.org/r/67659/diff/2/
Changes: https://reviews.apache.org/r/67659/diff/1-2/
Testing
-------
All tests pass.
Thanks,
Gordon Sim