You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/16 05:50:08 UTC
[GitHub] [iotdb] jixuan1989 opened a new pull request, #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
jixuan1989 opened a new pull request, #7120:
URL: https://github.com/apache/iotdb/pull/7120
see PR #7119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] liuminghui233 closed pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
liuminghui233 closed pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
URL: https://github.com/apache/iotdb/pull/7120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7120:
URL: https://github.com/apache/iotdb/pull/7120#issuecomment-1227720916
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7120)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL) [21 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=new_coverage&view=list) [45.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #7120:
URL: https://github.com/apache/iotdb/pull/7120#issuecomment-1226417326
[](https://coveralls.io/builds/51923889)
Coverage decreased (-0.009%) to 42.316% when pulling **cee697b6f49da01ba41a3d2b174e4452ad0801b4 on master-4230-shell1** into **4ad3915bd38456122b5e4f23280a7e155cb0ffd9 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7120:
URL: https://github.com/apache/iotdb/pull/7120#issuecomment-1226402498
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7120)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7120&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7120&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on PR #7120:
URL: https://github.com/apache/iotdb/pull/7120#issuecomment-1279898050
this PR is not ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7120:
URL: https://github.com/apache/iotdb/pull/7120#discussion_r954431498
##########
server/src/assembly/resources/sbin/start-server.sh:
##########
@@ -23,12 +23,37 @@ echo ---------------------
echo Starting IoTDB
echo ---------------------
+
+if [ "x$IOTDB_INCLUDE" = "x" ]; then
+ # Locations (in order) to use when searching for an include file.
+ for include in "`dirname "$0"`/iotdb.in.sh" \
+ "$HOME/.iotdb.in.sh" \
+ /usr/share/iotdb/iotdb.in.sh \
+ /etc/iotdb/iotdb.in.sh \
+ /opt/iotdb/iotdb.in.sh; do
+ if [ -r "$include" ]; then
+ . "$include"
+ break
+ fi
+ done
+# ...otherwise, source the specified include.
+elif [ -r "$CASSANDRA_INCLUDE" ]; then
+ . "$CASSANDRA_INCLUDE"
Review Comment:
```suggestion
elif [ -r "$IOTDB_INCLUDE" ]; then
. "$IOTDB_INCLUDE"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 closed pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
Posted by GitBox <gi...@apache.org>.
jixuan1989 closed pull request #7120: [IOTDB-4230]add checking iotdb.in.sh file, add iotdb_log_dir system variable
URL: https://github.com/apache/iotdb/pull/7120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org