You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/03/09 11:41:53 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #24525: Add global clock rule(#24519)
FlyingZC opened a new pull request, #24525:
URL: https://github.com/apache/shardingsphere/pull/24525
For #24519
Changes proposed in this pull request:
- Add global clock rule
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24525: Add global clock rule(#24519)
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24525:
URL: https://github.com/apache/shardingsphere/pull/24525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24525: Add global clock rule(#24519)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24525:
URL: https://github.com/apache/shardingsphere/pull/24525#issuecomment-1463080914
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24525](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dbb6cac) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ea06d6a506edc8186ab68e5dc6545b04ef510363?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea06d6a) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head dbb6cac differs from pull request most recent head 8a164d8. Consider uploading reports for the commit 8a164d8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24525 +/- ##
============================================
- Coverage 50.20% 50.15% -0.05%
Complexity 1599 1599
============================================
Files 3299 3308 +9
Lines 53981 54025 +44
Branches 9927 9930 +3
============================================
- Hits 27100 27098 -2
- Misses 24461 24506 +45
- Partials 2420 2421 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...core/exception/GlobalClockNotEnabledException.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL2V4Y2VwdGlvbi9HbG9iYWxDbG9ja05vdEVuYWJsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lclock/core/exception/GlobalClockSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL2V4Y2VwdGlvbi9HbG9iYWxDbG9ja1NRTEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...gsphere/globalclock/core/rule/GlobalClockRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL3J1bGUvR2xvYmFsQ2xvY2tSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/DefaultGlobalClockRuleConfigurationBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL3J1bGUvYnVpbGRlci9EZWZhdWx0R2xvYmFsQ2xvY2tSdWxlQ29uZmlndXJhdGlvbkJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lock/core/rule/builder/GlobalClockRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL3J1bGUvYnVpbGRlci9HbG9iYWxDbG9ja1J1bGVCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../yaml/config/YamlGlobalClockRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL3lhbWwvY29uZmlnL1lhbWxHbG9iYWxDbG9ja1J1bGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apper/YamlGlobalClockRuleConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay9jb3JlL3lhbWwvc3dhcHBlci9ZYW1sR2xvYmFsQ2xvY2tSdWxlQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lobalclock/type/tso/provider/LocalTSOProvider.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay90eXBlL3Rzby9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nbG9iYWxjbG9jay90eXBlL3Rzby9wcm92aWRlci9Mb2NhbFRTT1Byb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...lobalclock/type/tso/provider/RedisTSOProvider.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2dsb2JhbC1jbG9jay90eXBlL3Rzby9wcm92aWRlci9yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ2xvYmFsY2xvY2svdHlwZS90c28vcHJvdmlkZXIvUmVkaXNUU09Qcm92aWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...kend/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbmZpZy95YW1sL1lhbWxQcm94eVNlcnZlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `77.77% <ø> (ø)` | |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere/pull/24525/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org